You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by manjuapu <gi...@git.apache.org> on 2017/10/11 19:07:53 UTC
[GitHub] kafka-site pull request #96: Fixed video paramas
GitHub user manjuapu opened a pull request:
https://github.com/apache/kafka-site/pull/96
Fixed video paramas
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manjuapu/kafka-site streams-updates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka-site/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit d415111bcb15b5a4f7549ab410c85088a41d79f1
Author: Manjula K <ma...@kafka-summit.org>
Date: 2017-10-10T02:42:05Z
Change apache-kafka image permission as image not appearing in twitter
commit b5c717ad1ca107f838f8d9baee963d853a294a04
Author: Manjula K <ma...@kafka-summit.org>
Date: 2017-10-11T18:45:15Z
Fixed video paramas
----
---
[GitHub] kafka-site pull request #96: Fixed video paramas
Posted by manjuapu <gi...@git.apache.org>.
Github user manjuapu commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/96#discussion_r144151112
--- Diff: css/styles.css ---
@@ -1074,7 +1074,6 @@ nav .btn {
.sticky-top {
white-space: nowrap;
overflow-y: hidden;
- overflow-x: scroll;
--- End diff --
@guozhangwang Yes, these changes are different. I am changing &modestbranding=1&controls=2& to rel=0& for all the videos. Does this make sense?
---
[GitHub] kafka-site pull request #96: Fixed video paramas
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/96#discussion_r144150407
--- Diff: css/styles.css ---
@@ -1074,7 +1074,6 @@ nav .btn {
.sticky-top {
white-space: nowrap;
overflow-y: hidden;
- overflow-x: scroll;
--- End diff --
Are these changes on this file intentional? I'm asking because we already have lots of edits on this commit:
https://github.com/apache/kafka-site/pull/92/files
And I'm just double checking to see if any of them were unintentionally reverted in this PR.
---
[GitHub] kafka-site issue #96: Fixed video paramas
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on the issue:
https://github.com/apache/kafka-site/pull/96
LGTM. Merged to `asf-site`.
---
[GitHub] kafka-site issue #96: Fixed video paramas
Posted by manjuapu <gi...@git.apache.org>.
Github user manjuapu commented on the issue:
https://github.com/apache/kafka-site/pull/96
@guozhangwang Can you please review.
---
[GitHub] kafka-site pull request #96: Fixed video paramas
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka-site/pull/96
---