Re: Build of subversion failed with SWIG 4.4.0

[Andreas Stieger <An...@gmx.de>]

Hello,

looks like this was not picked up on -dev. Let me try.

> On Mon, Sep 15, 2025 at 7:54 AM Jitka Plesnikova <jp...@redhat.com> 
> wrote:
>
>     I am maintainer of SWIG in Fedora and new version of swig 4.4.0
>     should
>     appeared soon.
>     I ran test rebuild of subversion against future SWIG in FEDORA
>     rawhide
>     and it failed.
>
>     I reported it to SWIG upstream:
>     https://github.com/swig/swig/issues/3260
>
>     They did some investigation and proposed 3 possible solution.
>     https://github.com/swig/swig/issues/3260#issuecomment-3272521479
>
>     I tested options 2 and 3. Both of them solve the build issue.
>

This was reported on openSUSE as well: 
https://bugzilla.opensuse.org/show_bug.cgi?id=1252962

Proposing the below...

[[[
Fix build with swig 4.4.0

* subversion/bindings/swig/include/svn_types.swg
   (subversion/bindings/swig/include/svn_types.swg): Replace obsolete
   SWIG_Python_TypeError with SWIG_Error
]]]

Index: subversion/bindings/swig/include/svn_types.swg
===================================================================
--- subversion/bindings/swig/include/svn_types.swg      (revision 1929478)
+++ subversion/bindings/swig/include/svn_types.swg      (working copy)
@@ -656,7 +656,7 @@
  %typemap(in, noblock=1) apr_pool_t * {
    /* Verify that the user supplied a valid pool */
    if ($input != Py_None && $input != _global_py_pool) {
-    SWIG_Python_TypeError(SWIG_TypePrettyName($descriptor), $input);
+    SWIG_Error(SWIG_TypeError,  "expected '$type'");
      SWIG_arg_fail($svn_argnum);
      SWIG_fail;
    }