[jira] Reopened: (SM-1518) Aggregator keeps a list of closed aggregations causing a slight memory leak

["Ron Gavlin (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/activemq/browse/SM-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ron Gavlin reopened SM-1518:
----------------------------


The fix for 

http://fisheye6.atlassian.com/browse/servicemix/components/engines/servicemix-eip/trunk/src/main/java/org/apache/servicemix/eip/support/AbstractAggregator.java?r=687751#l302

introduced a regression. In the newly added code below, note that "store" should be replaced with "closedAggregates". Please fix ASAP. 

I would also suggest that a "closed Aggregation" unit test be written to hopefully catch this type of regression in the future.

- Ron

-    protected boolean isAggregationClosed(String correlationId) {
+    protected boolean isAggregationClosed(String correlationId) throws Exception {
         // TODO: implement this using a persistent / cached behavior
-        return closedAggregates.containsKey(correlationId);
+        Object data = store.load(correlationId);
+        if (data != null) {
+            store.store(correlationId, data);
+        }
+        return data != null;
     }


> Aggregator keeps a list of closed aggregations causing a slight memory leak
> ---------------------------------------------------------------------------
>
>                 Key: SM-1518
>                 URL: https://issues.apache.org/activemq/browse/SM-1518
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-eip
>    Affects Versions: 3.2.2
>            Reporter: Gert Vanthienen
>            Assignee: Gert Vanthienen
>            Priority: Minor
>             Fix For: 3.2.3, 3.3
>
>
> As explained in the javadoc:
> {code:java}
> TODO: keep list of closed aggregations for a certain time
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.