You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Mark Thomas <ma...@apache.org> on 2018/07/09 21:05:09 UTC
Fwd: [GitHub] beiwei30 closed pull request #2051: rename access log
in unit test from 'alibaba' to 'alibaba.log'
You should consider a further rename to remove the reference to alibaba
completely (and any similar file names). References to specific
commercial entities in the code can give the wrong impression regarding
project independence.
Mark
-------- Forwarded Message --------
Subject: [GitHub] beiwei30 closed pull request #2051: rename access log
in unit test from 'alibaba' to 'alibaba.log'
Date: Mon, 09 Jul 2018 06:44:52 -0000
From: GitBox <gi...@apache.org>
Reply-To: dev@dubbo.apache.org
To: notifications@dubbo.apache.org
beiwei30 closed pull request #2051: rename access log in unit test from
'alibaba' to 'alibaba.log' URL:
https://github.com/apache/incubator-dubbo/pull/2051
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
index 5db1127791..8e5c426697 100644
---
a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
+++
b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
@@ -57,7 +57,7 @@ public void testDefault() {
@Test
public void testCustom() {
- URL url = URL.valueOf("test://test:11/test?accesslog=alibaba");
+ URL url = URL.valueOf("test://test:11/test?accesslog=alibaba.log");
Invoker<AccessLogFilterTest> invoker = new
MyInvoker<AccessLogFilterTest>(url);
Invocation invocation = new MockInvocation();
accessLogFilter.invoke(invoker, invocation);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [GitHub] beiwei30 closed pull request #2051: rename access log in
unit test from 'alibaba' to 'alibaba.log'
Posted by Huxing Zhang <hu...@apache.org>.
On Tue, Jul 10, 2018 at 5:05 AM, Mark Thomas <ma...@apache.org> wrote:
> You should consider a further rename to remove the reference to alibaba
> completely (and any similar file names). References to specific
> commercial entities in the code can give the wrong impression regarding
> project independence.
+1. I would also suggest we do a thorough check for existing codes
and docuemention, to ensure all the name like com.alibaba are replaced
by org.apache.
I am planning to start to work on the documentation.
>
> Mark
>
>
> -------- Forwarded Message --------
> Subject: [GitHub] beiwei30 closed pull request #2051: rename access log
> in unit test from 'alibaba' to 'alibaba.log'
> Date: Mon, 09 Jul 2018 06:44:52 -0000
> From: GitBox <gi...@apache.org>
> Reply-To: dev@dubbo.apache.org
> To: notifications@dubbo.apache.org
>
> beiwei30 closed pull request #2051: rename access log in unit test from
> 'alibaba' to 'alibaba.log' URL:
> https://github.com/apache/incubator-dubbo/pull/2051
>
> This is a PR merged from a forked repository.
> As GitHub hides the original diff on merge, it is displayed below for
> the sake of provenance:
>
> As this is a foreign pull request (from a fork), the diff is supplied
> below (as it won't show otherwise due to GitHub magic):
>
> diff --git
> a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
> b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
> index 5db1127791..8e5c426697 100644
> ---
> a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
> +++
> b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
> @@ -57,7 +57,7 @@ public void testDefault() {
> @Test
> public void testCustom() {
> - URL url = URL.valueOf("test://test:11/test?accesslog=alibaba");
> + URL url = URL.valueOf("test://test:11/test?accesslog=alibaba.log");
> Invoker<AccessLogFilterTest> invoker = new
> MyInvoker<AccessLogFilterTest>(url);
> Invocation invocation = new MockInvocation();
> accessLogFilter.invoke(invoker, invocation);
>
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
> For additional commands, e-mail: notifications-help@dubbo.apache.org
>
--
Best Regards！
Huxing
Re: [GitHub] beiwei30 closed pull request #2051: rename access log in
unit test from 'alibaba' to 'alibaba.log'
Posted by Ian Luo <ia...@gmail.com>.
good suggestion, thanks Mark.
I will submit another checkin to rename this access log to more general
name.
On Tue, Jul 10, 2018 at 5:05 AM Mark Thomas <ma...@apache.org> wrote:
> You should consider a further rename to remove the reference to alibaba
> completely (and any similar file names). References to specific
> commercial entities in the code can give the wrong impression regarding
> project independence.
>
> Mark
>
>
> -------- Forwarded Message --------
> Subject: [GitHub] beiwei30 closed pull request #2051: rename access log
> in unit test from 'alibaba' to 'alibaba.log'
> Date: Mon, 09 Jul 2018 06:44:52 -0000
> From: GitBox <gi...@apache.org>
> Reply-To: dev@dubbo.apache.org
> To: notifications@dubbo.apache.org
>
> beiwei30 closed pull request #2051: rename access log in unit test from
> 'alibaba' to 'alibaba.log' URL:
> https://github.com/apache/incubator-dubbo/pull/2051
>
> This is a PR merged from a forked repository.
> As GitHub hides the original diff on merge, it is displayed below for
> the sake of provenance:
>
> As this is a foreign pull request (from a fork), the diff is supplied
> below (as it won't show otherwise due to GitHub magic):
>
> diff --git
>
> a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
>
> b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
> index 5db1127791..8e5c426697 100644
> ---
>
> a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
> +++
>
> b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java
> @@ -57,7 +57,7 @@ public void testDefault() {
> @Test
> public void testCustom() {
> - URL url = URL.valueOf("test://test:11/test?accesslog=alibaba");
> + URL url =
> URL.valueOf("test://test:11/test?accesslog=alibaba.log");
> Invoker<AccessLogFilterTest> invoker = new
> MyInvoker<AccessLogFilterTest>(url);
> Invocation invocation = new MockInvocation();
> accessLogFilter.invoke(invoker, invocation);
>
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
> For additional commands, e-mail: notifications-help@dubbo.apache.org
>
>