You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/27 05:43:24 UTC

[GitHub] [druid] clintropolis commented on issue #9425: allow optimization of single multi-value column input expr with repeated identifier

clintropolis commented on issue #9425: allow optimization of single multi-value column input expr with repeated identifier
URL: https://github.com/apache/druid/pull/9425#issuecomment-591793203
 
 
   >Can you think of a way to add a test? (The results don't change, we were just missing a performance optimization. We don't have a perf test framework yet, but even without one, any ideas?)
   
   It is pretty ugly, but I added a test to confirm that `SingleStringInputDimensionSelector` is chosen over `MultiValueExpressionDimensionSelector` for selectors with capabilities that are compatible with the optimization.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org