You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@paimon.apache.org by lz...@apache.org on 2023/05/16 09:01:35 UTC
[incubator-paimon] branch master updated: [bug] Fixed manifest list naming issue. (#1163)
This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-paimon.git
The following commit(s) were added to refs/heads/master by this push:
new 00fc3ebd3 [bug] Fixed manifest list naming issue. (#1163)
00fc3ebd3 is described below
commit 00fc3ebd3195e7ea73c31407fd4425d29968c5df
Author: Dian Qi <qi...@163.com>
AuthorDate: Tue May 16 17:01:31 2023 +0800
[bug] Fixed manifest list naming issue. (#1163)
---
.../src/main/java/org/apache/paimon/manifest/ManifestList.java | 2 +-
.../test/java/org/apache/paimon/manifest/ManifestListTest.java | 10 ++++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestList.java b/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestList.java
index c11536713..34ebe3308 100644
--- a/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestList.java
+++ b/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestList.java
@@ -110,7 +110,7 @@ public class ManifestList extends ObjectsFile<ManifestFileMeta> {
new ManifestFileMetaSerializer(),
fileFormat.createReaderFactory(metaType),
fileFormat.createWriterFactory(metaType),
- pathFactory.manifestFileFactory(),
+ pathFactory.manifestListFactory(),
cache);
}
}
diff --git a/paimon-core/src/test/java/org/apache/paimon/manifest/ManifestListTest.java b/paimon-core/src/test/java/org/apache/paimon/manifest/ManifestListTest.java
index 824d3e219..63e3676a5 100644
--- a/paimon-core/src/test/java/org/apache/paimon/manifest/ManifestListTest.java
+++ b/paimon-core/src/test/java/org/apache/paimon/manifest/ManifestListTest.java
@@ -29,6 +29,7 @@ import org.apache.paimon.utils.FailingFileIO;
import org.apache.paimon.utils.FileStorePathFactory;
import org.junit.jupiter.api.RepeatedTest;
+import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
import java.io.IOException;
@@ -74,6 +75,15 @@ public class ManifestListTest {
}
}
+ @Test
+ public void testManifestListNaming() {
+ List<ManifestFileMeta> metas = generateData();
+ ManifestList manifestList = createManifestList(tempDir.toString());
+
+ String manifestListName = manifestList.write(metas);
+ assertThat(manifestListName.startsWith("manifest-list-")).isTrue();
+ }
+
private List<ManifestFileMeta> generateData() {
Random random = new Random();
List<ManifestFileMeta> metas = new ArrayList<>();