You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2018/07/27 17:05:26 UTC

[GitHub] mbeckerle opened a new pull request #88: Daffodil 1919 separators

mbeckerle opened a new pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88
 
 
   Preliminary review of this large change set. 
   
   This is a rewrite of the way sequences and separators and repeating/scalar elements work.
   The old structure was really just not up to the job of implementing the required behavior for DFDL's separator suppression capabilities. 
   
   There is a lot of change here, but the primary architectural "twist" is that instead of sequence combinators being trivial, and complexity being in the repeating-element combinators, the new way has complex sequence combinators, that drive occurrence-at-a-time repeating-element combinators. That is, the driver loop isn't in the repeating element combinators, but in the sequence combinators.
   
   Also needed TDML "threePass" test capability. 
   
   Status:
      All basic sbt test tests run. 
       
       sbt it:test has 5 failures - all due to message output changing.
       test_3398_CLI_Debugger_occursBounds_2
       test_1336_CLI_Debugger_occursBounds
       test_3263_CLI_Debugger_occursBounds
       test_3227_CLI_Parsing_SimpleParse_DFDL1197_fix
       test_3266_CLI_Debugger_occursBounds_shortFor
       
       Of application schemas CSV, PCAP, mil-std-2045 work.
       
       NACHA does not work yet. Length mismatches in the unparsed output.
       This is a clue to the fact that daffodil, with these changes, is not
       implementing the same behavior it had before, which is also evidenced by the
       "threePass" tests.
   
   Other schemas have not been tried yet. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services