[jira] [Commented] (TS-992) Generic portability fixes.

["Piotr Sikora (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178251#comment-13178251 ] 

Piotr Sikora commented on TS-992:
---------------------------------

Hey Leif,
it looks that the changes you've made to patch 0011 in [#1215555|http://svn.apache.org/viewvc?view=rev&rev=1215555], that is, adding:
{code}
const_cast<const time_t *>
{code}
instead of:
{code}
(const time_t *)
{code}
don't really work and build fails with:
{code}
SysAPI.cc: In function 'int Time_GetTime(char*, size_t, char*, size_t, char*, size_t)':
SysAPI.cc:651: error: invalid const_cast from type 'long int*' to type 'const time_t*'
SysAPI.cc: In function 'int Time_GetDate(char*, size_t, char*, size_t, char*, size_t)':
SysAPI.cc:691: error: invalid const_cast from type 'long int*' to type 'time_t*'
ConfigCmd.cc: In function 'int ConfigDate(char*)':
ConfigCmd.cc:2645: error: invalid const_cast from type 'long int*' to type 'const time_t*'
ConfigCmd.cc: In function 'int ConfigTime(char*)':
ConfigCmd.cc:2729: error: invalid const_cast from type 'long int*' to type 'const time_t*'
{code}
                
> Generic portability fixes.
> --------------------------
>
>                 Key: TS-992
>                 URL: https://issues.apache.org/jira/browse/TS-992
>             Project: Traffic Server
>          Issue Type: Improvement
>         Environment: OpenBSD
>            Reporter: Piotr Sikora
>            Assignee: Leif Hedstrom
>            Priority: Minor
>             Fix For: 3.1.2
>
>         Attachments: 0001-iocore-s-swap-ts_swap-g.patch, 0001-iocore-s-swap-ts_swap-g.patch, 0002-iocore-don-t-mix-old-and-new-arpa-nameser.h-interfac.patch, 0003-mgmt-drop-getnetparms-it-isn-t-used-anywhere.patch, 0004-iocore-fix-incorrect-HostDBProcessor-getby-call.patch, 0005-tests-add-missing-link-time-flags.patch, 0006-proxy-NULL-is-defined-in-unistd.h.patch, 0007-iocore-guard-against-missing-ENOSR-and-EPROTO-defini.patch, 0008-proxy-fix-usage-of-NEED_ALTZONE_DEFINED.patch, 0009-proxy-fix-off-by-one-error-in-sscanf.patch, 0010-autoconf-improve-detection-of-available-system-heade.patch, 0011-mgmt-cast-localtime-argument-to-const-time_t.patch, 0012-examples-add-missing-sys-types.h-header.patch
>
>
> Bunch of patches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira