[GitHub] [druid] pjain1 commented on a change in pull request #9449: Add Sql InputSource

[GitBox <gi...@apache.org>]

pjain1 commented on a change in pull request #9449:
URL: https://github.com/apache/druid/pull/9449#discussion_r416549940



##########
File path: server/src/main/java/org/apache/druid/guice/FirehoseModule.java
##########
@@ -58,7 +59,8 @@ public void configure(Binder binder)
                 new NamedType(CombiningFirehoseFactory.class, "combining"),
                 new NamedType(FixedCountFirehoseFactory.class, "fixedCount"),
                 new NamedType(SqlFirehoseFactory.class, "sql"),
-                new NamedType(InlineFirehoseFactory.class, "inline")
+                new NamedType(InlineFirehoseFactory.class, "inline"),
+                new NamedType(SqlInputSource.class, "sql")

Review comment:
       can this be part of new module as InputSource seems to replacement for firehose related interfaces ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org