You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/08/11 01:15:08 UTC
Review Request 37324: Reintroduce "Regenerate Keytabs" button on
Admin->Kerberos page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37324/
-----------------------------------------------------------
Review request for Ambari, Robert Levas and Srimanth Gunturi.
Bugs: AMBARI-12707
https://issues.apache.org/jira/browse/AMBARI-12707
Repository: ambari
Description
-------
As part of AMBARI-12641, "Regenerate keytabs" button was removed from Admin->Kerberos page.
But It is reported to be a useful ux functionality and should be kept along with being able to update kerberos descriptor and generate keytabs.
As part of this ticket "Regenrate Keytabs" button is introduced again.
Diffs
-----
ambari-web/app/controllers/main/admin/kerberos.js 969c09a
ambari-web/app/styles/application.less 37f8c21
ambari-web/app/templates/main/admin/kerberos.hbs fcbad72
Diff: https://reviews.apache.org/r/37324/diff/
Testing
-------
Tested on a live cluster manually.
Verified that all ambari-web unit tests passess successfully with the patch:
6704 tests complete (10 seconds)
94 tests pending
Thanks,
Jaimin Jetly
Re: Review Request 37324: Reintroduce "Regenerate Keytabs" button on
Admin->Kerberos page
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37324/#review94826
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Aug. 10, 2015, 7:17 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37324/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 7:17 p.m.)
>
>
> Review request for Ambari, Robert Levas and Srimanth Gunturi.
>
>
> Bugs: AMBARI-12707
> https://issues.apache.org/jira/browse/AMBARI-12707
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As part of AMBARI-12641, "Regenerate keytabs" button was removed from Admin->Kerberos page.
> But It is reported to be a useful ux functionality and should be kept along with being able to update kerberos descriptor and generate keytabs.
> As part of this ticket "Regenrate Keytabs" button is introduced again.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/kerberos.js 969c09a
> ambari-web/app/styles/application.less 37f8c21
> ambari-web/app/templates/main/admin/kerberos.hbs fcbad72
>
> Diff: https://reviews.apache.org/r/37324/diff/
>
>
> Testing
> -------
>
> Tested on a live cluster manually.
> Verified that all ambari-web unit tests passess successfully with the patch:
>
>
> 6704 tests complete (10 seconds)
> 94 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 37324: Reintroduce "Regenerate Keytabs" button on
Admin->Kerberos page
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37324/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 11:17 p.m.)
Review request for Ambari, Robert Levas and Srimanth Gunturi.
Changes
-------
Removed a commented out code from the patch
Bugs: AMBARI-12707
https://issues.apache.org/jira/browse/AMBARI-12707
Repository: ambari
Description
-------
As part of AMBARI-12641, "Regenerate keytabs" button was removed from Admin->Kerberos page.
But It is reported to be a useful ux functionality and should be kept along with being able to update kerberos descriptor and generate keytabs.
As part of this ticket "Regenrate Keytabs" button is introduced again.
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/kerberos.js 969c09a
ambari-web/app/styles/application.less 37f8c21
ambari-web/app/templates/main/admin/kerberos.hbs fcbad72
Diff: https://reviews.apache.org/r/37324/diff/
Testing
-------
Tested on a live cluster manually.
Verified that all ambari-web unit tests passess successfully with the patch:
6704 tests complete (10 seconds)
94 tests pending
Thanks,
Jaimin Jetly