You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/31 20:01:29 UTC

[GitHub] [camel] ThePrez opened a new pull request #6019: [CAMEL-16907] camel-jt400 program call usability and doc improvements

ThePrez opened a new pull request #6019:
URL: https://github.com/apache/camel/pull/6019


   <!-- Uncomment and fill this section if your PR is not trivial
   - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
   - [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   Added usability improvements to the program call support as documented in the referenced JIRA issue. 
   
   Also, snuck in some doc improvements:
   - Stopped referring to it as "remote program call" as we have a lot of people running Camel on IBM i now
   - Removed the 'type' path parameter (it's not required since the type is inferred from the path)
   - added a more practical program call example


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #6019: [CAMEL-16907] camel-jt400 program call usability and doc improvements

Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #6019:
URL: https://github.com/apache/camel/pull/6019


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] ThePrez commented on pull request #6019: [CAMEL-16907] camel-jt400 program call usability and doc improvements

Posted by GitBox <gi...@apache.org>.
ThePrez commented on pull request #6019:
URL: https://github.com/apache/camel/pull/6019#issuecomment-909820853


   Converting to draft to add doc to more explicitly address concerns in [this JIRA ticket](https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-16899)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] ThePrez commented on pull request #6019: [CAMEL-16907] camel-jt400 program call usability and doc improvements

Posted by GitBox <gi...@apache.org>.
ThePrez commented on pull request #6019:
URL: https://github.com/apache/camel/pull/6019#issuecomment-910876556


   I pushed a couple more commits. https://github.com/apache/camel/pull/6019/commits/e2d604389539c960d6c3bbc8504ae9f95a9fc1cb stops handling input parameters based on whether it's in binary mode. In the old design, binary mode required a `byte[]` and text mode required a `String`, now it is tolerant enough to accept either. 
   
   https://github.com/apache/camel/pull/6019/commits/e54d7099cb3dccc12450138b6e1a04dfd842a520 clarifies the parameter handling in the documentation to address the concern in CAMEL-16899


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] ThePrez commented on pull request #6019: [CAMEL-16907] camel-jt400 program call usability and doc improvements

Posted by GitBox <gi...@apache.org>.
ThePrez commented on pull request #6019:
URL: https://github.com/apache/camel/pull/6019#issuecomment-909820853


   Converting to draft to add doc to more explicitly address concerns in [this JIRA ticket](https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-16899)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org