You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/04 02:03:57 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

HyukjinKwon opened a new pull request #34481:
URL: https://github.com/apache/spark/pull/34481


   ### What changes were proposed in this pull request?
   
   This PR is a minor folllowup that proposes to move `python/pyproject.toml` to `dev/pyproject.toml`.
   
   ### Why are the changes needed?
   
   `pyproject.toml` can potentially affect how PySpark package interacts with pip. For example, the fork of PySpark in Databricks attempts to build a wheel as a test. Previously, it passed permissively but now it fails as below:
   
   ```
   ERROR: Could not build wheels for pyspark, which is required to install pyproject.toml-based projects
   ```
   
   Since `python/pyproject.toml` is only for tests, it should be best to minimise such potential impact.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Leveraged the CI in the fork.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-960453843


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144889/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-960453843


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144889/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-960449829


   **[Test build #144889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144889/testReport)** for PR 34481 at commit [`efe2675`](https://github.com/apache/spark/commit/efe2675c785ae1b59a658157c1b9b8d5b49f8d40).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-960429629


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49359/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34481:
URL: https://github.com/apache/spark/pull/34481


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-960429629


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49359/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-960367310


   **[Test build #144889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144889/testReport)** for PR 34481 at commit [`efe2675`](https://github.com/apache/spark/commit/efe2675c785ae1b59a658157c1b9b8d5b49f8d40).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-960419554


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49359/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-961584372






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-960367310


   **[Test build #144889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144889/testReport)** for PR 34481 at commit [`efe2675`](https://github.com/apache/spark/commit/efe2675c785ae1b59a658157c1b9b8d5b49f8d40).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-960384817


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49359/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34481:
URL: https://github.com/apache/spark/pull/34481






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #34481: [SPARK-36989][TESTS][PYTHON][FOLLOW-UP] Move pyproject.toml from python to dev directory

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34481:
URL: https://github.com/apache/spark/pull/34481#issuecomment-961584372


   Merged to master.
   
   
   Thanks @dongjoon-hyun and @zero323.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org