You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/20 03:56:04 UTC

[GitHub] [pulsar] merlimat opened a new pull request #9649: Added metrics for producer throttling

merlimat opened a new pull request #9649:
URL: https://github.com/apache/pulsar/pull/9649


   ### Motivation
   
   Added counters to track connections being throttled for outstanding messages or for reached global mem limit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on pull request #9649: Added metrics for producer throttling

Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #9649:
URL: https://github.com/apache/pulsar/pull/9649#issuecomment-786059818


   @Anonymitaet This is only from 2.8. Yes, we should have the new metric on `site2/docs/reference-metrics.md`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on pull request #9649: Added metrics for producer throttling

Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #9649:
URL: https://github.com/apache/pulsar/pull/9649#issuecomment-784389764


   > Looks good to me, could you please add a test for the new metrics? Avoid breaking it in future versions
   
   The metrics are static in the broker so it's very difficult to test them cleanly in isolation when the unit tests are running multiple broker instances


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #9649: Added metrics for producer throttling

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #9649:
URL: https://github.com/apache/pulsar/pull/9649#issuecomment-791093234


   @merlimat thanks. Could you please help add docs accordingly? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #9649: Added metrics for producer throttling

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #9649:
URL: https://github.com/apache/pulsar/pull/9649#issuecomment-785556917


   @merlimat thanks for your coding work.
   
   1. Does this apply to 2.7.1?
   
   2. Would you like to add docs for this change?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #9649: Added metrics for producer throttling

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9649:
URL: https://github.com/apache/pulsar/pull/9649


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org