You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Michael Osipov <mi...@apache.org> on 2021/05/25 16:27:32 UTC

Renamings with APR removal in 10.1.x

Mark,

since you are going to remove all bits soon, will you rename Java items 
with still carry the APR substring? E.g., AprLifecycleListener will be a 
misleading name for obvious reasons.

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Renamings with APR removal in 10.1.x

Posted by Michael Osipov <mi...@apache.org>.
Am 2021-05-26 um 15:29 schrieb Mark Thomas:
> On 25/05/2021 17:27, Michael Osipov wrote:
>> Mark,
>>
>> since you are going to remove all bits soon, will you rename Java 
>> items with still carry the APR substring? E.g., AprLifecycleListener 
>> will be a misleading name for obvious reasons.
> 
> I hadn't considered that but it seems like a good opportunity to remove 
> some of the confusion that that naming has caused. I think a switch to 
> TomcatNativeLifecylcleListener would work.
> 
> My expectation is that in the early milestone releases for 10.1.x that 
> the listener looks for Tomcat Native 1.2.x but at some point before the 
> first stable release it switches to Tomcat Native 2.0.x. That assumes we 
> find the time to create Tomcat Native 2.0.x. Given that it will mostly 
> be deleting code, that should be doable.

Have also a look at build.xml: test.apr.loc should also be renamed to 
test.tomcat-native.loc.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Renamings with APR removal in 10.1.x

Posted by Rémy Maucherat <re...@apache.org>.
On Wed, May 26, 2021 at 3:29 PM Mark Thomas <ma...@apache.org> wrote:

> On 25/05/2021 17:27, Michael Osipov wrote:
> > Mark,
> >
> > since you are going to remove all bits soon, will you rename Java items
> > with still carry the APR substring? E.g., AprLifecycleListener will be a
> > misleading name for obvious reasons.
>
> I hadn't considered that but it seems like a good opportunity to remove
> some of the confusion that that naming has caused. I think a switch to
> TomcatNativeLifecylcleListener would work.
>
> My expectation is that in the early milestone releases for 10.1.x that
> the listener looks for Tomcat Native 1.2.x but at some point before the
> first stable release it switches to Tomcat Native 2.0.x. That assumes we
> find the time to create Tomcat Native 2.0.x. Given that it will mostly
> be deleting code, that should be doable.
>

Nice plan.

Rémy


>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

Re: Renamings with APR removal in 10.1.x

Posted by Mark Thomas <ma...@apache.org>.
On 25/05/2021 17:27, Michael Osipov wrote:
> Mark,
> 
> since you are going to remove all bits soon, will you rename Java items 
> with still carry the APR substring? E.g., AprLifecycleListener will be a 
> misleading name for obvious reasons.

I hadn't considered that but it seems like a good opportunity to remove 
some of the confusion that that naming has caused. I think a switch to 
TomcatNativeLifecylcleListener would work.

My expectation is that in the early milestone releases for 10.1.x that 
the listener looks for Tomcat Native 1.2.x but at some point before the 
first stable release it switches to Tomcat Native 2.0.x. That assumes we 
find the time to create Tomcat Native 2.0.x. Given that it will mostly 
be deleting code, that should be doable.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org