You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/03/25 16:22:30 UTC
[GitHub] incubator-brooklyn pull request: UsageListener: improve API
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/572
UsageListener: improve API
- Deprecates old interface
- Adds new UsageListener interface that is more flexible and more backwards compatible.
- Marks new interface as @Beta
- Adds tests for new UsageListener, and refactors old tests for old-style UsageListener.
- Adds Entities.proxy(Entity)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn refactor/UsageListener
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/572.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #572
----
commit 859f0c9185435b789776025e78d80541adc07feb
Author: Aled Sage <al...@gmail.com>
Date: 2015-03-25T14:58:48Z
UsageListener: improve API
- Deprecates old interface
- Adds new UsageListener interface that is more flexible and
more backwards compatible.
- Marks new interface as @Beta
- Adds tests for new UsageListener, and refactors old tests for
old-style UsageListener.
- Adds Entities.proxy(Entity)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: UsageListener: improve API
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/572#issuecomment-86617046
Thanks @nakomis - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: UsageListener: improve API
Posted by nakomis <gi...@git.apache.org>.
Github user nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/572#issuecomment-86550162
Looks good, tests pass. Have also done some testing / changes against this branch and it seems to work :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: UsageListener: improve API
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---