You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "maytasm (via GitHub)" <gi...@apache.org> on 2023/05/02 07:08:41 UTC
[GitHub] [spark] maytasm opened a new pull request, #41012: [SPARK-43337][UI] Asc/desc arrow icons for sorting column does not get displayed in the table column
maytasm opened a new pull request, #41012:
URL: https://github.com/apache/spark/pull/41012
### What changes were proposed in this pull request? Update javascript library DataTables, used in the UI, to 1.13.2.
### Why are the changes needed?
DataTables 1.10.25 broke asc/desc arrow icons for sorting column. The sorting icon is not displayed when the column is clicked to sort by asc/desc. Upgrading DataTables to 1.13.2 fixes this issue.
The 1.10.25 version of DataTables, that Spark currently uses, seems vulerable: https://security.snyk.io/package/npm/datatables.net/1.10.25. The vulnerability may not affect Spark but it is safer to update.
### Does this PR introduce _any_ user-facing change? No.
### How was this patch tested?
Manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maytasm commented on pull request #41012: [SPARK-43337][UI][3.3] Asc/desc arrow icons for sorting column does not get displayed in the table column
Posted by "maytasm (via GitHub)" <gi...@apache.org>.
maytasm commented on PR #41012:
URL: https://github.com/apache/spark/pull/41012#issuecomment-1531988820
> BTW, please remove this from the PR description, @maytasm .
>
> > The 1.10.25 version of DataTables, that Spark currently uses, seems vulerable: https://security.snyk.io/package/npm/datatables.net/1.10.25. The vulnerability may not affect Spark but it is safer to update.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #41012: [SPARK-43337][UI][3.3] Asc/desc arrow icons for sorting column does not get displayed in the table column
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #41012: [SPARK-43337][UI][3.3] Asc/desc arrow icons for sorting column does not get displayed in the table column
URL: https://github.com/apache/spark/pull/41012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maytasm commented on pull request #41012: [SPARK-43337][UI][3.3] Asc/desc arrow icons for sorting column does not get displayed in the table column
Posted by "maytasm (via GitHub)" <gi...@apache.org>.
maytasm commented on PR #41012:
URL: https://github.com/apache/spark/pull/41012#issuecomment-1531988614
> I agree with back-porting. We just need to get tests to pass. Did the UI seem OK in a quick manual test? just want to verify the arrows work.
Do you know why the `On pull request update / Notify test workflow` failed? Looks like all the tests passed on https://github.com/apache/spark/pull/41011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maytasm commented on pull request #41012: [SPARK-43337][UI][3.3] Asc/desc arrow icons for sorting column does not get displayed in the table column
Posted by "maytasm (via GitHub)" <gi...@apache.org>.
maytasm commented on PR #41012:
URL: https://github.com/apache/spark/pull/41012#issuecomment-1535811262
@srowen @dongjoon-hyun
Here is a simple CSS fix instead: https://github.com/apache/spark/pull/41060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maytasm commented on pull request #41012: [SPARK-43337][UI][3.3] Asc/desc arrow icons for sorting column does not get displayed in the table column
Posted by "maytasm (via GitHub)" <gi...@apache.org>.
maytasm commented on PR #41012:
URL: https://github.com/apache/spark/pull/41012#issuecomment-1531989351
> Is this the only way to fix the issue, @maytasm ?
https://github.com/apache/spark/pull/41011#issuecomment-1531983883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maytasm commented on pull request #41012: [SPARK-43337][UI] Asc/desc arrow icons for sorting column does not get displayed in the table column
Posted by "maytasm (via GitHub)" <gi...@apache.org>.
maytasm commented on PR #41012:
URL: https://github.com/apache/spark/pull/41012#issuecomment-1530992792
@srowen @gengliangwang
Address issue mentioned in https://github.com/apache/spark/pull/36226#issuecomment-1530789474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #41012: [SPARK-43337][UI][3.3] Asc/desc arrow icons for sorting column does not get displayed in the table column
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41012:
URL: https://github.com/apache/spark/pull/41012#issuecomment-1536422538
Yeah let's go with your alternative
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #41012: [SPARK-43337][UI] Asc/desc arrow icons for sorting column does not get displayed in the table column
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41012:
URL: https://github.com/apache/spark/pull/41012#issuecomment-1531534005
I agree with back-porting. We just need to get tests to pass. Did the UI seem OK in a quick manual test? just want to verify the arrows work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org