You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/09/07 03:48:22 UTC
[GitHub] [skywalking-java] pg-yang opened a new pull request, #304: Config support Set parameter
pg-yang opened a new pull request, #304:
URL: https://github.com/apache/skywalking-java/pull/304
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
Set is faster than List for detecting value if exist . and could remove duplicate value too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on pull request #304: Support set-type in the agent or plugin configurations
Posted by GitBox <gi...@apache.org>.
pg-yang commented on PR #304:
URL: https://github.com/apache/skywalking-java/pull/304#issuecomment-1238889548
Try to support Set<String> , String<Integer> , etc .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #304: Support set-type in the agent or plugin configurations
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #304:
URL: https://github.com/apache/skywalking-java/pull/304#issuecomment-1238890286
I mean the codes are converting to set string forcely, no matter what generic type declared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #304: Config support Set parameter
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #304:
URL: https://github.com/apache/skywalking-java/pull/304#discussion_r964355992
##########
CHANGES.md:
##########
@@ -5,6 +5,7 @@ Release Notes.
8.13.0
------------------
+* Config support Set parameter
Review Comment:
```suggestion
* support set-type in the agent or plugin configurations.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #304: Support set-type in the agent or plugin configurations
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #304:
URL: https://github.com/apache/skywalking-java/pull/304#issuecomment-1238901973
Yes, based on your codes, I believe you still would add string in to int set.
We should convert configuration to the expected type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #304: Support set/hashset/treeSet/arraylist/linkedlist types in the agent and plugin configurations
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #304:
URL: https://github.com/apache/skywalking-java/pull/304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on pull request #304: Support set-type in the agent or plugin configurations
Posted by GitBox <gi...@apache.org>.
pg-yang commented on PR #304:
URL: https://github.com/apache/skywalking-java/pull/304#issuecomment-1238902983
OK, I'll support all `java.util.Collection` . It's better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on pull request #304: Support set-type in the agent or plugin configurations
Posted by GitBox <gi...@apache.org>.
pg-yang commented on PR #304:
URL: https://github.com/apache/skywalking-java/pull/304#issuecomment-1239124946
PING
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #304: Support set-type in the agent or plugin configurations
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #304:
URL: https://github.com/apache/skywalking-java/pull/304#issuecomment-1238887327
Set is a generic type, I noticed you only support String Set?
You should read the generic type and convert element type too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on pull request #304: Support set-type in the agent or plugin configurations
Posted by GitBox <gi...@apache.org>.
pg-yang commented on PR #304:
URL: https://github.com/apache/skywalking-java/pull/304#issuecomment-1238896719
Are you mean Java-generics ? like Set<String> , Set<Integer> ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #304: Support set-type in the agent or plugin configurations
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #304:
URL: https://github.com/apache/skywalking-java/pull/304#issuecomment-1238887288
Set is a generic type, I noticed you only support String Set?
You should read the generic type and convert element type too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org