You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2026/06/11 01:17:16 UTC

[PR] Minor refactor SQLE2ETestCaseAssertion [shardingsphere]

strongduanmu opened a new pull request, #38841:
URL: https://github.com/apache/shardingsphere/pull/38841

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     - Minor refactor SQLE2ETestCaseAssertion
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor refactor SQLE2ETestCaseAssertion [shardingsphere]

Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC merged PR #38841:
URL: https://github.com/apache/shardingsphere/pull/38841


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor refactor SQLE2ETestCaseAssertion [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #38841:
URL: https://github.com/apache/shardingsphere/pull/38841#issuecomment-4676680887

     ### Summary
   
     - **Merge Decision: Mergeable**
     - **Reason:** The refactor fixes the parameter parsing path for values containing colons, and the changed E2E configuration does not show a concrete regression risk in the current scope.
   
     ### Evidence
   
     - `SQLE2ETestCaseAssertion#getSQLValues()` now parses each parameter by the last colon, which fits existing E2E parameter values such as `12:30:30:time` and timestamp values containing colons.
     - SQL E2E has passed, so the changed parsing path is covered through the actual E2E prepared-statement usage path.
     - The added MySQL `plugin_dir` setting is limited to E2E container configuration, and there is no plugin installation/loading path in this PR, so no concrete runtime behavior regression is identified for the reviewed scope.
     - No substantive production code, public API/SPI, parser grammar, dependency, packaging, release note, or user documentation impact was found.
   
     ### Review Details
   
     - **Reviewed Scope:** PR #38841 latest head `0bc15db637db17918bc0c03139e61e3a58e19afb`; 5 changed files under SQL E2E assertion parsing and MySQL E2E container configs.
     - **Not Reviewed Scope:** Full local Maven/E2E execution was not rerun in this review.
     - **Verification:** Reviewed PR diff and GitHub file list; user confirmed CI E2E has passed.
     - **Release Note / User Docs:** Not required, because this is test framework / E2E resource maintenance with no user-facing product behavior change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org