You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sarutak <gi...@git.apache.org> on 2014/07/17 20:14:15 UTC
[GitHub] spark pull request: [SPARK-2542] Exit Code Class should be renamed...
GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/1467
[SPARK-2542] Exit Code Class should be renamed and placed package properly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarutak/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1467.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1467
----
commit 01acd8e9033045d9d5f9d5c230c427a007535cdb
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date: 2014-07-17T18:11:34Z
Renamed and repackaged ExecutorExitCode.scala properly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2542] Exit Code Class should be renamed...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1467#issuecomment-49390495
It doesn't seem obvious to me that we should rename this. The primary purpose here is to describe reasons why executors can fail. There is a slight corner case here where someone does a local job execution inside of the driver, I don't think that warrants changing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2542] Exit Code Class should be renamed...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1467#issuecomment-49343702
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2542] Exit Code Class should be renamed...
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/1467#issuecomment-51745751
O.K. I got it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2542] Exit Code Class should be renamed...
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak closed the pull request at:
https://github.com/apache/spark/pull/1467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org