[GitHub] [airflow] WestonKing-Leatham commented on pull request #27389: Replace urlparse with urlsplit in s3 files

[GitBox <gi...@apache.org>]

WestonKing-Leatham commented on PR #27389:
URL: https://github.com/apache/airflow/pull/27389#issuecomment-1296481792

   > why are you say `urlsplit` is faster and lighterweight? python official docs not record it, even, I didn't find any other information recommending use `urlsplit`.
   
   Its not much faster and maybe its a bit overselling it to be calling it lighterweight, but it is faster as it doesn't try to parse the url for params. The [second sentence here](https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlsplit) of python docs on it says "This should generally be used instead of urlparse()".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org