You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by "Jeff MAURY (JIRA)" <ji...@apache.org> on 2008/06/24 15:34:45 UTC
[jira] Created: (WODEN-211) Refactor directory layout to be more
Maven compliant
Refactor directory layout to be more Maven compliant
----------------------------------------------------
Key: WODEN-211
URL: https://issues.apache.org/jira/browse/WODEN-211
Project: Woden
Issue Type: Improvement
Reporter: Jeff MAURY
Priority: Minor
The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
Re: [jira] Commented: (WODEN-211) Refactor directory layout to be more Maven compliant
Posted by "John Kaputin (gmail)" <ja...@gmail.com>.
Jeff,
I would prefer to keep the change to the converter package name (from
org.apache.woden.tool.converter to org.apache.woden.converter), as the new
directory structure eliminates the need to use 'tool' as a package
qualifier. I assume the maven build will create a woden-tool.jar file.
However, we will need to warn the Woden community of this change before
committing to trunk. I'd like to hear what other woden developers think.
regards,
John.
On Tue, Aug 5, 2008 at 3:21 PM, Jeff MAURY <je...@jeffmaury.com> wrote:
> I was my mistake. My intent was to not modify the code and packages
> structure so if it happened, it should be reverted to the old package unless
> the woden community agrees to do so.
>
> Jeff MAURY
>
>
> On Tue, Aug 5, 2008 at 2:27 AM, John Kaputin (gmail) <ja...@gmail.com>wrote:
>
>> I noticed that the package names for the 2 tools (converter and
>> wsdl-viewer) use different styles:
>>
>> The converter package name under the java folder is
>> org.apache.woden.converter (it used to be org.apache.woden.tool.converter)
>> The wsdl-viewer directory structure under the css and javascript folders
>> is org/apache/woden/tool/wsdl-viewer.
>>
>> I don't mind dropping 'tool' from the package or directory path, as both
>> tools are now located under woden-tool, but should we make it consistent and
>> drop 'tool' from the wsdl-viewer directory structure too?
>>
>> Also, is there a way to group the files under woden-tool to make it
>> clearer whether they are for the converter or wsdl-viewer, without breaking
>> Maven compliance? At the moment all tools files are grouped by file type
>> (css, java, javascript, xslt) and you need to look into the sub-directory
>> structure or at the actual file names to work out which tool.
>>
>> regards,
>> John.
>>
>>
>> On Mon, Aug 4, 2008 at 9:54 PM, John Kaputin (JIRA) <ji...@apache.org>wrote:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619517#action_12619517]
>>>
>>> John Kaputin commented on WODEN-211:
>>> ------------------------------------
>>>
>>> I had to make a small code change to get the new woden source tree to
>>> compile in Eclipse. The declared package for the 2 converter classes was
>>> org.apache.woden.tool.converter, but under the new woden-tool/src/main/java
>>> directory the actual package name has been changed to
>>> org.apache.woden.converter (i.e. 'tool' has been dropped). I changed the
>>> declared package in these 2 classes to match. If this package name change
>>> was intentional, I can commit my change to the woden211/trunk branch and/or
>>> upload a patch.
>>>
>>> > Refactor directory layout to be more Maven compliant
>>> > ----------------------------------------------------
>>> >
>>> > Key: WODEN-211
>>> > URL: https://issues.apache.org/jira/browse/WODEN-211
>>> > Project: Woden
>>> > Issue Type: Improvement
>>> > Reporter: Jeff MAURY
>>> > Assignee: Jeremy Hughes
>>> > Priority: Minor
>>> > Attachments: trunk.zip
>>> >
>>> >
>>> > The directory layout should be refactored in order to follow Maven
>>> conventions. Today, there are dependencies between the Woden modules which
>>> miss flexibility.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
>>> For additional commands, e-mail: woden-dev-help@ws.apache.org
>>>
>>>
>>
>
>
> --
> La mélancolie c'est communiste
> Tout le monde y a droit de temps en temps
> La mélancolie n'est pas capitaliste
> C'est même gratuit pour les perdants
> La mélancolie c'est pacifiste
> On ne lui rentre jamais dedans
> La mélancolie oh tu sais ça existe
> Elle se prend même avec des gants
> La mélancolie c'est pour les syndicalistes
> Il faut juste sa carte de permanent
>
> Miossec (2006)
>
> http://www.jeffmaury.com
> http://riadiscuss.jeffmaury.com
> http://www.lastfm.fr/listen/user/jeffmaury/personal
> Mes CDs à récupérer:
> http://spreadsheets.google.com/ccc?key=pNeg4Doa_oCsh7CepKPaPTA&hl=en
>
Re: [jira] Commented: (WODEN-211) Refactor directory layout to be more Maven compliant
Posted by Jeff MAURY <je...@jeffmaury.com>.
I was my mistake. My intent was to not modify the code and packages
structure so if it happened, it should be reverted to the old package unless
the woden community agrees to do so.
Jeff MAURY
On Tue, Aug 5, 2008 at 2:27 AM, John Kaputin (gmail) <ja...@gmail.com>wrote:
> I noticed that the package names for the 2 tools (converter and
> wsdl-viewer) use different styles:
>
> The converter package name under the java folder is
> org.apache.woden.converter (it used to be org.apache.woden.tool.converter)
> The wsdl-viewer directory structure under the css and javascript folders is
> org/apache/woden/tool/wsdl-viewer.
>
> I don't mind dropping 'tool' from the package or directory path, as both
> tools are now located under woden-tool, but should we make it consistent and
> drop 'tool' from the wsdl-viewer directory structure too?
>
> Also, is there a way to group the files under woden-tool to make it clearer
> whether they are for the converter or wsdl-viewer, without breaking Maven
> compliance? At the moment all tools files are grouped by file type (css,
> java, javascript, xslt) and you need to look into the sub-directory
> structure or at the actual file names to work out which tool.
>
> regards,
> John.
>
>
> On Mon, Aug 4, 2008 at 9:54 PM, John Kaputin (JIRA) <ji...@apache.org>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619517#action_12619517]
>>
>> John Kaputin commented on WODEN-211:
>> ------------------------------------
>>
>> I had to make a small code change to get the new woden source tree to
>> compile in Eclipse. The declared package for the 2 converter classes was
>> org.apache.woden.tool.converter, but under the new woden-tool/src/main/java
>> directory the actual package name has been changed to
>> org.apache.woden.converter (i.e. 'tool' has been dropped). I changed the
>> declared package in these 2 classes to match. If this package name change
>> was intentional, I can commit my change to the woden211/trunk branch and/or
>> upload a patch.
>>
>> > Refactor directory layout to be more Maven compliant
>> > ----------------------------------------------------
>> >
>> > Key: WODEN-211
>> > URL: https://issues.apache.org/jira/browse/WODEN-211
>> > Project: Woden
>> > Issue Type: Improvement
>> > Reporter: Jeff MAURY
>> > Assignee: Jeremy Hughes
>> > Priority: Minor
>> > Attachments: trunk.zip
>> >
>> >
>> > The directory layout should be refactored in order to follow Maven
>> conventions. Today, there are dependencies between the Woden modules which
>> miss flexibility.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: woden-dev-help@ws.apache.org
>>
>>
>
--
La mélancolie c'est communiste
Tout le monde y a droit de temps en temps
La mélancolie n'est pas capitaliste
C'est même gratuit pour les perdants
La mélancolie c'est pacifiste
On ne lui rentre jamais dedans
La mélancolie oh tu sais ça existe
Elle se prend même avec des gants
La mélancolie c'est pour les syndicalistes
Il faut juste sa carte de permanent
Miossec (2006)
http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.lastfm.fr/listen/user/jeffmaury/personal
Mes CDs à récupérer:
http://spreadsheets.google.com/ccc?key=pNeg4Doa_oCsh7CepKPaPTA&hl=en
Re: [jira] Commented: (WODEN-211) Refactor directory layout to be more Maven compliant
Posted by "John Kaputin (gmail)" <ja...@gmail.com>.
I noticed that the package names for the 2 tools (converter and wsdl-viewer)
use different styles:
The converter package name under the java folder is
org.apache.woden.converter (it used to be org.apache.woden.tool.converter)
The wsdl-viewer directory structure under the css and javascript folders is
org/apache/woden/tool/wsdl-viewer.
I don't mind dropping 'tool' from the package or directory path, as both
tools are now located under woden-tool, but should we make it consistent and
drop 'tool' from the wsdl-viewer directory structure too?
Also, is there a way to group the files under woden-tool to make it clearer
whether they are for the converter or wsdl-viewer, without breaking Maven
compliance? At the moment all tools files are grouped by file type (css,
java, javascript, xslt) and you need to look into the sub-directory
structure or at the actual file names to work out which tool.
regards,
John.
On Mon, Aug 4, 2008 at 9:54 PM, John Kaputin (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619517#action_12619517]
>
> John Kaputin commented on WODEN-211:
> ------------------------------------
>
> I had to make a small code change to get the new woden source tree to
> compile in Eclipse. The declared package for the 2 converter classes was
> org.apache.woden.tool.converter, but under the new woden-tool/src/main/java
> directory the actual package name has been changed to
> org.apache.woden.converter (i.e. 'tool' has been dropped). I changed the
> declared package in these 2 classes to match. If this package name change
> was intentional, I can commit my change to the woden211/trunk branch and/or
> upload a patch.
>
> > Refactor directory layout to be more Maven compliant
> > ----------------------------------------------------
> >
> > Key: WODEN-211
> > URL: https://issues.apache.org/jira/browse/WODEN-211
> > Project: Woden
> > Issue Type: Improvement
> > Reporter: Jeff MAURY
> > Assignee: Jeremy Hughes
> > Priority: Minor
> > Attachments: trunk.zip
> >
> >
> > The directory layout should be refactored in order to follow Maven
> conventions. Today, there are dependencies between the Woden modules which
> miss flexibility.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: woden-dev-help@ws.apache.org
>
>
[jira] Updated: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sagara Gunathunga updated WODEN-211:
-------------------------------------
Attachment: woden-test-pom-impl-om.xml.txt
woden-test-pom-impl-dom.xml.txt
woden-api-pom.xml.txt
fixes for some of the test failing scenarios.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip, woden-api-pom.xml.txt, woden-test-pom-impl-dom.xml.txt, woden-test-pom-impl-om.xml.txt
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749777#action_12749777 ]
Sagara Gunathunga commented on WODEN-211:
------------------------------------------
revision: 809838 - merged to the trunk.
Thanks Jeff for your initial contribution for this.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip, woden-api-pom.xml.txt, woden-test-pom-impl-dom.xml.txt, woden-test-pom-impl-om.xml.txt
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615915#action_12615915 ]
Jeremy Hughes commented on WODEN-211:
-------------------------------------
Thanks Jeff. I'll take a look.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Resolved: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sagara Gunathunga resolved WODEN-211.
--------------------------------------
Resolution: Fixed
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip, woden-api-pom.xml.txt, woden-test-pom-impl-dom.xml.txt, woden-test-pom-impl-om.xml.txt
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619517#action_12619517 ]
John Kaputin commented on WODEN-211:
------------------------------------
I had to make a small code change to get the new woden source tree to compile in Eclipse. The declared package for the 2 converter classes was org.apache.woden.tool.converter, but under the new woden-tool/src/main/java directory the actual package name has been changed to org.apache.woden.converter (i.e. 'tool' has been dropped). I changed the declared package in these 2 classes to match. If this package name change was intentional, I can commit my change to the woden211/trunk branch and/or upload a patch.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sagara Gunathunga updated WODEN-211:
-------------------------------------
Fix Version/s: M9
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Fix For: M9
>
> Attachments: trunk.zip, woden-api-pom.xml.txt, woden-test-pom-impl-dom.xml.txt, woden-test-pom-impl-om.xml.txt
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Assigned: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin reassigned WODEN-211:
----------------------------------
Assignee: Jeremy Hughes
Assigning to Jeremy, who has volunteered to review patches contributed by Jeff. Thanks Jeremy.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Assigned: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hughes reassigned WODEN-211:
-----------------------------------
Assignee: Jeremy Hughes (was: Jeff MAURY)
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Jeff MAURY (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff MAURY updated WODEN-211:
-----------------------------
Attachment: trunk.zip
I have started the Maven refactoring. The result is stored in the attached trunk.zip file. Here are some comments on what I have done and some remaining issues.
As discussed, I have created the following modules under trunk:
woden-api: core interfaces and classes
woden-commons: common classes shared by woden implementations, as of yet woden-dom and woden-om
woden-dom: DOM based woden implementation
woden-om: OM based woden implementation
woden-ant: woden Ant task
woden-tool: converted and WSDL viewer
woden-tests: common tests for OM and DOM implementations
The philosophy I used for tests is that if the test is not specific to an implementation, then it is under woden-tests and it will be run against both implementations. I do not used the tests suite pattern but run all tests against both implementations: as of yet, some of them fails so I modified the poms to let the build succeed and the failed tests will be indicated so that we can know the real status of the build
No files have been created except for POMs. When moving files, I first checked if I can move directories and in the negative choice, I then moved files in order to decrease the SVN operations.
The ant build has been modified as well with the same philosophy for tests.
Issues to be addressed:
- failed tests
- QName: under woden-api but I think we need to find a dependency (maybe look at Axis2 to check how they do)
- common files; all the licenses files are directly under trunk, and each submodule pom specify this directory as a resource directory but this is not Maven compliant: maybe we must use the maven resource plugin to import these files
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeff MAURY
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Jeff MAURY (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627594#action_12627594 ]
Jeff MAURY commented on WODEN-211:
----------------------------------
Sorry guys for being so long but I'm just back from a 3 weeks holiday and I forget to set a vacation message on gmail.
I was running Maven from the root pom (multi module) so I don't know why you did get errors because there is a pom.xml in the woden-tests directory in the zip file I sent to the Woden community (along with two other poms pom-impl-dom.xml and pom-impl-om.xml). I looked at the SVN branch and it seems the content is not complete.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626106#action_12626106 ]
Jeremy Hughes commented on WODEN-211:
-------------------------------------
OK. I've got passed this by having the Woden top level pom.xml declare the Apache parent pom as its parent pom. This is because the Apache parent pom declares the location of the Apache m2 snapshot repository, which contains the XmlSchema project snapshots. So I can now get through to the install stage of the mvn lifecycle successfully. But without woden-tests or woden-tool.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626098#action_12626098 ]
Jeremy Hughes commented on WODEN-211:
-------------------------------------
Starting from a cleaned out local repository. Then by commenting out the woden-tests and woden-tool modules in the top level pom.xml and figuring out that I need to run mvn install (otherwise the woden-impl-commons artifact isn't in the local repository for woden-impl-dom to use) then I get this:
{code}
[INFO] Failed to resolve artifact.
Missing:
----------
1) org.apache.ws.commons.schema:XmlSchema:jar:SNAPSHOT
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=org.apache.ws.commons.schema -DartifactId=XmlSchema -Dversion=SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file
Alternatively, if you host your own repository you can deploy the file there:
mvn deploy:deploy-file -DgroupId=org.apache.ws.commons.schema -DartifactId=XmlSchema -Dversion=SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
Path to dependency:
1) org.apache.woden:woden:pom:1.0-SNAPSHOT
2) org.apache.ws.commons.schema:XmlSchema:jar:SNAPSHOT
2) org.apache.ws.commons.axiom:axiom-api:jar:SNAPSHOT
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=org.apache.ws.commons.axiom -DartifactId=axiom-api -Dversion=SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file
Alternatively, if you host your own repository you can deploy the file there:
mvn deploy:deploy-file -DgroupId=org.apache.ws.commons.axiom -DartifactId=axiom-api -Dversion=SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
Path to dependency:
1) org.apache.woden:woden:pom:1.0-SNAPSHOT
2) org.apache.ws.commons.axiom:axiom-api:jar:SNAPSHOT
3) org.apache.ws.commons.axiom:axiom-impl:jar:SNAPSHOT
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=org.apache.ws.commons.axiom -DartifactId=axiom-impl -Dversion=SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file
Alternatively, if you host your own repository you can deploy the file there:
mvn deploy:deploy-file -DgroupId=org.apache.ws.commons.axiom -DartifactId=axiom-impl -Dversion=SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
Path to dependency:
1) org.apache.woden:woden:pom:1.0-SNAPSHOT
2) org.apache.ws.commons.axiom:axiom-impl:jar:SNAPSHOT
----------
3 required artifacts are missing.
for artifact:
org.apache.woden:woden:pom:1.0-SNAPSHOT
from the specified remote repositories:
central (http://repo1.maven.org/maven2)
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2 minutes 56 seconds
[INFO] Finished at: Wed Aug 27 14:02:27 BST 2008
[INFO] Final Memory: 5M/14M
[INFO] ------------------------------------------------------------------------
{code}
Any ideas?
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627793#action_12627793 ]
Jeremy Hughes commented on WODEN-211:
-------------------------------------
I can see what's happened. The trunk.zip attachment has some files including woden-tests/pom.xml which haven't had svn add run on them. So when I created the woden211 branch they weren't checked in. I'll go through and check what else is missing.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710402#action_12710402 ]
Sagara Gunathunga commented on WODEN-211:
------------------------------------------
I have tested this branch and fixed some of the test failing scenarios as follows.
(1) woden-api module
'QNameDeserializeTest' test case failed, because this should be run only with JDK1.4 not with Java5 or higher version, "woden-api-pom.xml.txt" patch add a Maven profile so that above test case will run only with JDK1.4 .
(2) woden -test module
(a) 'W3CTestSuiteTest' failed , in Woden this test is not run as a normal JUnit test ,instead this is run via /ant-test/build.xml.
(b) Still some of the tests does not supports for OM based implementation, the approach used here is run all the test cases and ignore the failures, one weakness of this approach is test phase does not make any impact on build cycle . use of "excludes" test cases property with testFailureIgnore ="false" would be a better option here .
(woden-test-pom-impl-dom.xml.txt and woden-test-pom-impl-om.xml.txt address (a) and (b).)
(3) W3C test suite is run via /ant-test/build.xml and results are compared to W3C baseline ,It's required implement this functionality with Maven POM file , since WODEN-170 already related to this, i will update WODEN-170.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip, woden-api-pom.xml.txt, woden-test-pom-impl-dom.xml.txt, woden-test-pom-impl-om.xml.txt
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749258#action_12749258 ]
Sagara Gunathunga commented on WODEN-211:
------------------------------------------
revision: 809339
Fixed Maven based issues on woden-api and woden-test modules.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip, woden-api-pom.xml.txt, woden-test-pom-impl-dom.xml.txt, woden-test-pom-impl-om.xml.txt
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626067#action_12626067 ]
Jeremy Hughes commented on WODEN-211:
-------------------------------------
Hi Jeff,
I've been trying out the woden211 using the mvn command line. Maybe my expectation is wrong, but if I run mvn test in the top level directory I'd expect all the modules to build and tests to be run. But I get the following:
org.apache.maven.reactor.MavenExecutionException: Could not find the model file 'D:\woden\woden211\woden-tests\pom.xml'. for project unknown
because there isn't one. How are you running mvn?
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Assigned: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin reassigned WODEN-211:
----------------------------------
Assignee: Jeff MAURY (was: Jeremy Hughes)
Jeff is actually doing the work, so I think this should be assigned to him. My mistake.
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeff MAURY
> Priority: Minor
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-211) Refactor directory layout to be more
Maven compliant
Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732691#action_12732691 ]
Sagara Gunathunga commented on WODEN-211:
------------------------------------------
Since WODEN -170 issue is resolved it is possible build this branch successfully .
> Refactor directory layout to be more Maven compliant
> ----------------------------------------------------
>
> Key: WODEN-211
> URL: https://issues.apache.org/jira/browse/WODEN-211
> Project: Woden
> Issue Type: Improvement
> Reporter: Jeff MAURY
> Assignee: Jeremy Hughes
> Priority: Minor
> Attachments: trunk.zip, woden-api-pom.xml.txt, woden-test-pom-impl-dom.xml.txt, woden-test-pom-impl-om.xml.txt
>
>
> The directory layout should be refactored in order to follow Maven conventions. Today, there are dependencies between the Woden modules which miss flexibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org