You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jay Kreps <bo...@gmail.com> on 2014/02/12 02:12:06 UTC
Re: Review Request 17977: Patch for KAFKA-1257
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17977/
-----------------------------------------------------------
(Updated Feb. 12, 2014, 1:12 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1257
Bugs: KAFKA-1257
https://issues.apache.org/jira/browse/KAFKA-1257
Repository: kafka
Description
-------
KAFKA-1257 Only send metadata requests to nodes with no in-flight requests.
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java e8c194c8cdee570f7e3f5a48efa32f5f5c0bc9a4
Diff: https://reviews.apache.org/r/17977/diff/
Testing
-------
Thanks,
Jay Kreps
Re: Review Request 17977: Patch for KAFKA-1257
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17977/#review34252
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Feb. 12, 2014, 1:14 a.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17977/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 1:14 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1257
> https://issues.apache.org/jira/browse/KAFKA-1257
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1257 Only send metadata requests to nodes with no in-flight requests.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java e8c194c8cdee570f7e3f5a48efa32f5f5c0bc9a4
>
> Diff: https://reviews.apache.org/r/17977/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>
Re: Review Request 17977: Patch for KAFKA-1257
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17977/#review34248
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On Feb. 12, 2014, 1:14 a.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17977/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 1:14 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1257
> https://issues.apache.org/jira/browse/KAFKA-1257
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1257 Only send metadata requests to nodes with no in-flight requests.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java e8c194c8cdee570f7e3f5a48efa32f5f5c0bc9a4
>
> Diff: https://reviews.apache.org/r/17977/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>
Re: Review Request 17977: Patch for KAFKA-1257
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17977/
-----------------------------------------------------------
(Updated Feb. 12, 2014, 1:14 a.m.)
Review request for kafka.
Bugs: KAFKA-1257
https://issues.apache.org/jira/browse/KAFKA-1257
Repository: kafka
Description
-------
KAFKA-1257 Only send metadata requests to nodes with no in-flight requests.
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java e8c194c8cdee570f7e3f5a48efa32f5f5c0bc9a4
Diff: https://reviews.apache.org/r/17977/diff/
Testing
-------
Thanks,
Jay Kreps