You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/04/27 17:12:46 UTC

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1142: DISPATCH-2046: Removed the connector lock and used the server lock

kgiusti commented on a change in pull request #1142:
URL: https://github.com/apache/qpid-dispatch/pull/1142#discussion_r621254289



##########
File path: src/server.c
##########
@@ -1372,6 +1391,7 @@ void qd_server_free(qd_server_t *qd_server)
     if (!qd_server) return;
 
     qd_http_server_free(qd_server->http);
+    qd_timer_visit(true);

Review comment:
       I don't think this is the correct approach because this will mask leaking timers.
   
   If there are any timers still around when the router is being shutdown that means the owner of those timers never got around to properly cleaning them up.   That's a bug which will be hidden with the above patch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org