[GitHub] jiazhai closed pull request #1273: Use final variables in BoundedScheduledExecutorService

[GitBox <gi...@apache.org>]

jiazhai closed pull request #1273: Use final variables in BoundedScheduledExecutorService
URL: https://github.com/apache/bookkeeper/pull/1273
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/BoundedScheduledExecutorService.java b/bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/BoundedScheduledExecutorService.java
index b7b91510e..482ca1898 100644
--- a/bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/BoundedScheduledExecutorService.java
+++ b/bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/BoundedScheduledExecutorService.java
@@ -42,9 +42,9 @@
  */
 public class BoundedScheduledExecutorService extends ForwardingListeningExecutorService
         implements ListeningScheduledExecutorService {
-    BlockingQueue<Runnable> queue;
-    ListeningScheduledExecutorService thread;
-    int maxTasksInQueue;
+    private final BlockingQueue<Runnable> queue;
+    private final ListeningScheduledExecutorService thread;
+    private final int maxTasksInQueue;
 
     public BoundedScheduledExecutorService(ScheduledThreadPoolExecutor thread, int maxTasksInQueue) {
         this.queue = thread.getQueue();


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services