You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2018/12/23 05:06:00 UTC
[jira] [Commented] (SOLR-12535) Remove syntax for providing index
boosts in Solr's JSON update syntax
[ https://issues.apache.org/jira/browse/SOLR-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727800#comment-16727800 ]
David Smiley commented on SOLR-12535:
-------------------------------------
In the attached patch I did what the issue description says. "boost" isn't parsed, and there's no general "extended value" syntax; either a JSON object is interpreted as a child doc or a partial update; nothing else. This helped simplify some logic so I did some refactoring here as well. It was weird that a SolrInputField was being passed around and that some of these methods returned void. Now they all return the parsed value, and some take the field name to aid in reporting an error message.
Care to review [~moshebla]?
> Remove syntax for providing index boosts in Solr's JSON update syntax
> ---------------------------------------------------------------------
>
> Key: SOLR-12535
> URL: https://issues.apache.org/jira/browse/SOLR-12535
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Fix For: master (8.0)
>
> Attachments: SOLR-12535.patch
>
>
> In Solr 7 we can't index boost as it's gone from Lucene. The JSON support for this syntax is still allowed but logs a warning and doesn't apply the boost (as it's not supported). I'm proposing we remove support for this altogether. This also means removing an little-known way to specify an "extended field value" that doesn't necessarily have a boost.
> With boost: Today logs a warning. *Don't want this to work at all.*
> {code:java}
> [{'id':'1', 'val_s':{'value':'foo', 'boost':2.0}}]
> {code}
> Without boost: Today works. *Don't want this to work at all,* as it complicates support for labelled child documents – SOLR-12362.
> {code:java}
> [{'id':'1', 'val_s':{'value':'foo'}}]
> {code}
> Internally this is parsed by
> org.apache.solr.handler.loader.JsonLoader.SingleThreadedJsonLoader#parseExtendedFieldValue
> I think we need make no reference to the notion of an "extended field value". Either we have a "partial update", or we have a "child document"; nothing else.
> [https://lucene.apache.org/solr/guide/7_3/updating-parts-of-documents.html]
> Note: partial updates look similar and have exactly one field-value using a limited set of verbs like "set":
> {code:java}
> [{'id':'1', 'val_s':{'set':'foo'}}]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org