You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/25 09:41:06 UTC

[PR] Register BVal constraint validators for native tests [shardingsphere]

terrymanu opened a new pull request, #39960:
URL: https://github.com/apache/shardingsphere/pull/39960

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Register BVal constraint validators for native tests [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39960:
URL: https://github.com/apache/shardingsphere/pull/39960


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Register BVal constraint validators for native tests [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39960:
URL: https://github.com/apache/shardingsphere/pull/39960#issuecomment-5830253365

   ### Result
   
   **Review Result: Mergeable** — The local metadata change fixes the BVal validator reflection gaps observed in this NativeTest run. This is a local code review result; remote CI was not reviewed.
   
   ### Evidence
   
   - BVal loads validator class names from the already available `DefaultConstraints.properties` and instantiates them dynamically. The native image lacked the required reflection registrations. A missing resource bundle was not the cause of these failures.
   - The shared reachability metadata now registers only the no-argument constructors of `PatternValidator`, `NumberSignValidator$ForPositive`, and `NumberSignValidator$ForPositive$OrZero`, conditioned on `RuleConfigurationValidator`. No initialization options were added.
   - JSON parsing and `git diff --check` passed. This JSON file is outside the repository’s Spotless and Checkstyle formatting scopes.
   - The full NativeTest run reported `BUILD SUCCESS`: 24 tests found, 1 skipped, and all 23 executed tests passed. The previously failing Shadow, Postgres, and Doris tests passed in this run.
   
   ### Coverage
   
   - Standalone local candidate based on `ba7c4b835529db2a65e6db4978e3e888dd8e87e6`. The reviewed change consists of 36 added lines in `infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/infra-reachability-metadata/reachability-metadata.json`.
   - The review covered the call path, BVal classes and constructors, packaged metadata, change scope, and full local test run. No public interface was added. No remaining test failures or further changes required for this PR were found. Optional probe warnings still appear at startup but did not cause test failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org