[jira] Updated: (MAHOUT-355) Misleading JavaDoc comment in FPGrowth

["Sebastian Schelter (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAHOUT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebastian Schelter updated MAHOUT-355:
--------------------------------------

    Status: Patch Available  (was: Open)

I added a null check in the code, changed the JavaDoc to state that you can give null or an empty set to the method and added a trivial unit test.

> Misleading JavaDoc comment in FPGrowth
> --------------------------------------
>
>                 Key: MAHOUT-355
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-355
>             Project: Mahout
>          Issue Type: Bug
>          Components: Frequent Itemset/Association Rule Mining
>    Affects Versions: 0.3, 0.2
>            Reporter: Sebastian Schelter
>            Priority: Trivial
>         Attachments: MAHOUT-355.patch
>
>
> The JavaDoc for org.apache.mahout.fpm.pfpgrowth.fpgrowth.FPGrowth.generateTopKFrequentPatterns(...) states that if the parameter returnableFeatures is null then patterns for every frequent item are generated. 
> But this works only if you give the method an empty set, submitting null results in a NullPointerException. Either change the comment or do a null check here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.