You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/12 04:56:55 UTC
[GitHub] [solr] dsmiley opened a new pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_
dsmiley opened a new pull request #629:
URL: https://github.com/apache/solr/pull/629
https://issues.apache.org/jira/browse/SOLR-15064
Thankfully I left a number of hints back when this hack was added so that it wasn't hard to remove the substance of the change. The real work was updating the tests which were written to assume that. I can also see that you used to get an error if you used a wrong _route_ param that conflicted with the _root_ field of the doc you provide but it's now re-routed. I didn't expect that but it's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #629:
URL: https://github.com/apache/solr/pull/629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #629:
URL: https://github.com/apache/solr/pull/629#issuecomment-1044981233
I think `getSelfOrNestedDocIdStr` is definitely clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #629:
URL: https://github.com/apache/solr/pull/629#issuecomment-1044844311
Great point Houston. While I'm at it, I rather unlike the method name for getChildDocIdStr. As documented, it's the ID for the document itself -- and for a typical doc, it's *not* a child document. Perhaps this could be named `getSelfOrNestedDocIdStr` ? I recall the problem I was avoiding was making the method name something simple like `getDocIdStr` because it's too tempting to call this when the caller really ought to be calling `getIndexedId`[Str] in most cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #629:
URL: https://github.com/apache/solr/pull/629#issuecomment-1042380759
This is not extremely relevant to this PR, but it's something I ran into recently and this is an opportune time to bring it up 🙂
Due to the major refactoring you did earlier, `AddUpdateCommand` provides different id methods than it used to. Would you mind adding some info to the javaDocs for which methods return the document's `id` that can be used to determine the shard to route to? Basically, which id should be used in: `compositeIdRouter.sliceHash(id, doc, null, coll)`? I know some users that were confused by the removal of `getHashableId()` when trying to update custom plugins. I gave my best guess, but I'd prefer it included in the javaDocs since it seems like a good thing to explicitly call out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org