Re: [PR] HDDS-11226. Make ExponentialBackoffPolicy maxRetries configurable [ozone]

["kerneltime (via GitHub)" <gi...@apache.org>]

kerneltime commented on code in PR #6985:
URL: https://github.com/apache/ozone/pull/6985#discussion_r1695891810


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/conf/RatisClientConfig.java:
##########
@@ -203,6 +203,21 @@ public void setExponentialPolicyMaxSleep(Duration duration) {
     exponentialPolicyMaxSleep = duration;
   }
 
+  @Config(key = "client.exponential.backoff.max.retries",
+      defaultValue =  "2147483647",

Review Comment:
   You could define 
   ```
     private final static string intMax = Integer.toString(Integer.MAX_VALUE);
   ``` 
   in this class and then assign defaultValue = intMax?



##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/conf/RatisClientConfig.java:
##########
@@ -203,6 +203,21 @@ public void setExponentialPolicyMaxSleep(Duration duration) {
     exponentialPolicyMaxSleep = duration;
   }
 
+  @Config(key = "client.exponential.backoff.max.retries",
+      defaultValue =  "2147483647",

Review Comment:
   You could define 
   ```
     private final static string intMax = Integer.toString(Integer.MAX_VALUE);
   ``` 
   in this class and then assign `defaultValue = intMax`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org