You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/02 12:40:51 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #11141: fix(examples): missing expressions in birth_names
villebro opened a new pull request #11141:
URL: https://github.com/apache/incubator-superset/pull/11141
### SUMMARY
The metadata fetch call in `load-examples` erases the added `num_california` and `sum__num` expressions. By fetching before adding the expressions they are not erased prior to the commit.
### BEFORE
### AFTER
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #11141: fix(examples): missing expressions in birth_names
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11141:
URL: https://github.com/apache/incubator-superset/pull/11141#issuecomment-702948991
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11141?src=pr&el=h1) Report
> Merging [#11141](https://codecov.io/gh/apache/incubator-superset/pull/11141?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e90c63fc7b911efc16919abf5b017aa0f6250985?el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11141?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11141 +/- ##
==========================================
+ Coverage 65.80% 65.86% +0.05%
==========================================
Files 826 826
Lines 39019 39032 +13
Branches 3667 3677 +10
==========================================
+ Hits 25678 25709 +31
+ Misses 13231 13213 -18
Partials 110 110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.21% <ø> (-0.13%)` | :arrow_down: |
| #javascript | `62.20% <ø> (-0.02%)` | :arrow_down: |
| #python | `61.35% <100.00%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11141?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <100.00%> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `73.07% <0.00%> (-11.54%)` | :arrow_down: |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `75.64% <0.00%> (-5.13%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.21% <0.00%> (-1.79%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `82.35% <0.00%> (-0.85%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `89.69% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.30% <0.00%> (+0.24%)` | :arrow_up: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `71.36% <0.00%> (+0.45%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.39% <0.00%> (+0.82%)` | :arrow_up: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `51.63% <0.00%> (+1.30%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/11141/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11141?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11141?src=pr&el=footer). Last update [e90c63f...08c5e9f](https://codecov.io/gh/apache/incubator-superset/pull/11141?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #11141: fix(examples): missing expressions in birth_names
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #11141:
URL: https://github.com/apache/incubator-superset/pull/11141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org