You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "fangyincheng (GitHub)" <gi...@apache.org> on 2020/01/04 11:26:01 UTC

[GitHub] [dubbo-go] fangyincheng opened pull request #302: Imp: receive heartbeat from server

**What this PR does**:

    receive heartbeat package from server of java

**Which issue(s) this PR fixes**:

Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:

```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/302 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #302: Imp: receive heartbeat from server

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=h1) Report
> Merging [#302](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6f6377ebca2e67b10fd8d9f4589370254fbcd0c?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `45.83%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/302/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #302      +/-   ##
===========================================
- Coverage    65.81%   65.73%   -0.09%     
===========================================
  Files          112      112              
  Lines         7173     7182       +9     
===========================================
  Hits          4721     4721              
- Misses        1991     1998       +7     
- Partials       461      463       +2
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <100%> (+0.39%)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `70.27% <28.57%> (-6.21%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `50.28% <42.85%> (-0.91%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=footer). Last update [c6f6377...53bb7fb](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/302 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #302: Imp: receive heartbeat from server

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=h1) Report
> Merging [#302](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6f6377ebca2e67b10fd8d9f4589370254fbcd0c?src=pr&el=desc) will **increase** coverage by `0.73%`.
> The diff coverage is `58.33%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/302/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #302      +/-   ##
===========================================
+ Coverage    65.81%   66.55%   +0.73%     
===========================================
  Files          112      112              
  Lines         7173     7182       +9     
===========================================
+ Hits          4721     4780      +59     
+ Misses        1991     1936      -55     
- Partials       461      466       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.73% <100%> (+2.83%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `60.69% <50%> (+9.5%)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `75.67% <57.14%> (-0.8%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `74.63% <0%> (+15.12%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=footer). Last update [c6f6377...e0e015c](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/302 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed pull request #302: Imp: receive heartbeat from server

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/302 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed pull request #302: Imp: receive heartbeat from server

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/302 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #302: Imp: receive heartbeat from server

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@f1b5d12`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `75.85%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/302/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##             develop     #302   +/-   ##
==========================================
  Coverage           ?   66.55%           
==========================================
  Files              ?      112           
  Lines              ?     7182           
  Branches           ?        0           
==========================================
  Hits               ?     4780           
  Misses             ?     1936           
  Partials           ?      466
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <ø> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `58.53% <ø> (ø)` | |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `51.51% <ø> (ø)` | |
| [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80% <ø> (ø)` | |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.54% <ø> (ø)` | |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `57.8% <ø> (ø)` | |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `50% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `59.25% <ø> (ø)` | |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <ø> (ø)` | |
| [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0% <ø> (ø)` | |
| ... and [43 more](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=footer). Last update [f1b5d12...53bb7fb](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/302 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #302: Imp: receive heartbeat from server

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@f1b5d12`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `75.85%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/302/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##             develop     #302   +/-   ##
==========================================
  Coverage           ?   66.55%           
==========================================
  Files              ?      112           
  Lines              ?     7182           
  Branches           ?        0           
==========================================
  Hits               ?     4780           
  Misses             ?     1936           
  Partials           ?      466
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <ø> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `58.53% <ø> (ø)` | |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `51.51% <ø> (ø)` | |
| [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80% <ø> (ø)` | |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.54% <ø> (ø)` | |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `57.8% <ø> (ø)` | |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `50% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `59.25% <ø> (ø)` | |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <ø> (ø)` | |
| [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0% <ø> (ø)` | |
| ... and [43 more](https://codecov.io/gh/apache/dubbo-go/pull/302/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=footer). Last update [f1b5d12...e0e015c](https://codecov.io/gh/apache/dubbo-go/pull/302?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/302 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org