You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/27 09:34:39 UTC

[GitHub] [airflow] ashb commented on a change in pull request #12466: Adds support for Connection/Hook discovery from providers

ashb commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r531483119



##########
File path: airflow/providers/microsoft/mssql/hooks/mssql.py
##########
@@ -70,3 +71,9 @@ def set_autocommit(
 
     def get_autocommit(self, conn: pymssql.connect):  # pylint: disable=c-extension-no-member
         return conn.autocommit_state
+
+
+class MsSqlHookWithOdbcHook(OdbcHook):
+    """Interact with Microsoft SQL Server via ODBC."""
+
+    conn_type = 'mssql'

Review comment:
       Don't we need 
   
   
   ```suggestion
       conn_type = 'mssql'
       conn_name_attr = 'mssql_conn_id'
       default_conn_name = 'mssql_default'
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org