You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Alexis Midon (JIRA)" <ji...@apache.org> on 2008/12/12 01:57:44 UTC

[jira] Created: (BUILDR-227) Commit relative path instead of absolute path

Commit relative path instead of absolute path
---------------------------------------------

                 Key: BUILDR-227
                 URL: https://issues.apache.org/jira/browse/BUILDR-227
             Project: Buildr
          Issue Type: Bug
          Components: Core features
    Affects Versions: 1.3.4
            Reporter: Alexis Midon
             Fix For: 1.3.4


When I do a release with 'git version 1.5.2.5' I get this exception:

error: pathspec '/home/alexis/ode.git/Buildfile' did not match any file(s) known to git.

Actually this version of Git does not accept the absolute path, the path must be relative to the repository top directory. With 'git version 1.5.6.3' (and above), this bug does not occur.

Considering that we already enforce the release to be run from the top directory and that all VCS accept relative paths (AFAIK), don't you think it would be worth committing the relative path to the buildfile?

The patch would be:
in core/build.rb, def commit_new_snapshot
File.basename(Buildr.application.buildfile.to_s.)




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-227) Commit relative path instead of absolute path

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655874#action_12655874 ] 

Assaf Arkin commented on BUILDR-227:
------------------------------------

If there's a bug in BUILDR-222, why not discuss and fix it as part of BUILDR-222?

And as I commented before (on BUILDR-222) you can only generalize Git/SVN so far, but one is distributed version control, the other is not, and at some point forcefully trying to define common feature leads to masking differences and confusing code.  Remove the forced generalization and the problem will go away with Git support code doing what Git needs, and SVN support code doing what SVN needs.

> Commit relative path instead of absolute path
> ---------------------------------------------
>
>                 Key: BUILDR-227
>                 URL: https://issues.apache.org/jira/browse/BUILDR-227
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.4
>            Reporter: Alexis Midon
>             Fix For: 1.3.4
>
>
> When I do a release with 'git version 1.5.2.5' I get this exception:
> error: pathspec '/home/alexis/ode.git/Buildfile' did not match any file(s) known to git.
> Actually this version of Git does not accept the absolute path, the path must be relative to the repository top directory. With 'git version 1.5.6.3' (and above), this bug does not occur.
> Considering that we already enforce the release to be run from the top directory and that all VCS accept relative paths (AFAIK), don't you think it would be worth committing the relative path to the buildfile?
> The patch would be:
> in core/build.rb, def commit_new_snapshot
> File.basename(Buildr.application.buildfile.to_s.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (BUILDR-227) Commit relative path instead of absolute path

Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexis Midon closed BUILDR-227.
-------------------------------

    Resolution: Duplicate

see BUILDR-222

> Commit relative path instead of absolute path
> ---------------------------------------------
>
>                 Key: BUILDR-227
>                 URL: https://issues.apache.org/jira/browse/BUILDR-227
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.4
>            Reporter: Alexis Midon
>             Fix For: 1.3.4
>
>
> When I do a release with 'git version 1.5.2.5' I get this exception:
> error: pathspec '/home/alexis/ode.git/Buildfile' did not match any file(s) known to git.
> Actually this version of Git does not accept the absolute path, the path must be relative to the repository top directory. With 'git version 1.5.6.3' (and above), this bug does not occur.
> Considering that we already enforce the release to be run from the top directory and that all VCS accept relative paths (AFAIK), don't you think it would be worth committing the relative path to the buildfile?
> The patch would be:
> in core/build.rb, def commit_new_snapshot
> File.basename(Buildr.application.buildfile.to_s.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.