You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/07 09:50:52 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request, #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version
Pearl1594 opened a new pull request, #6227:
URL: https://github.com/apache/cloudstack/pull/6227
### Description
This PR fixes the value set for `minreq.sysvmtemplate.version` when upgrading to 4.17. Because of the value being hard-coded to 4.16.0 at https://github.com/apache/cloudstack/blob/main/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41610to41700.java#L73 it doesn't pick the right value, i.e., 4.16.1
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Upgrade from 4.16 to 4.17 and validate the global setting minreq.sysvmtemplate.version value
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6227:
URL: https://github.com/apache/cloudstack/pull/6227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6227:
URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091753032
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6227:
URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091710514
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6227:
URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091710154
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6227:
URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091758189
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6227:
URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091757388
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6227:
URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1092294820
<b>Trillian test result (tid-3840)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33094 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6227-t3840-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org