You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kamesh Jayachandran <ka...@collab.net> on 2007/03/14 15:18:50 UTC
[PATCH][merge-tracking]Remove redundant code
Hi All,
Find the attached patch and log.
With regards
Kamesh Jayachandran
Re: [PATCH][merge-tracking]Remove redundant code
Posted by Daniel Rall <dl...@collab.net>.
On Wed, 14 Mar 2007, Paul Burba wrote:
> > -----Original Message-----
> > From: Kamesh Jayachandran [mailto:kamesh@collab.net]
> > Sent: Wednesday, March 14, 2007 11:19 AM
> > To: SVN Dev
> > Subject: [PATCH][merge-tracking]Remove redundant code
> >
> > Hi All,
> > Find the attached patch and log.
>
> +1 on that change, thanks!
>
> Re your log message, it seems common to preface the first line of the
> log message for merge tracking branch commits with "On the
> merge-tracking branch:" I don't see any specific guidance about this in
> HACKING, but it's certainly our de facto practice for this branch. I
> guess this is really a question...Dan, any opinion on this?
I really prefer the "On the xxx-branch: " prefix. After the
merge-tracking branch is merged into trunk, this process facilitates
great information from the nested log messages view of merged
revisions that Hyrum is working on.
RE: [PATCH][merge-tracking]Remove redundant code
Posted by Paul Burba <pb...@collab.net>.
> -----Original Message-----
> From: Kamesh Jayachandran [mailto:kamesh@collab.net]
> Sent: Wednesday, March 14, 2007 11:19 AM
> To: SVN Dev
> Subject: [PATCH][merge-tracking]Remove redundant code
>
> Hi All,
> Find the attached patch and log.
+1 on that change, thanks!
Re your log message, it seems common to preface the first line of the
log message for merge tracking branch commits with "On the
merge-tracking branch:" I don't see any specific guidance about this in
HACKING, but it's certainly our de facto practice for this branch. I
guess this is really a question...Dan, any opinion on this?
> With regards
> Kamesh Jayachandran
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH][merge-tracking]Remove redundant code
Posted by Daniel Rall <dl...@collab.net>.
Kamesh, I (accidentally) committed your patch in r23818, along with
some stylistic changes. Nice catch!
- Dan