You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2019/03/14 07:19:00 UTC
[jira] [Commented] (HIVE-21369) LLAP: Logging is expensive in
encoded reader path
[ https://issues.apache.org/jira/browse/HIVE-21369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792419#comment-16792419 ]
Hive QA commented on HIVE-21369:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 9s{color} | {color:blue} ql in master has 2257 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 14s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 43s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16500/dev-support/hive-personality.sh |
| git revision | master / c1c3461 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-16500/yetus/patch-asflicense-problems.txt |
| modules | C: ql U: ql |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16500/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> LLAP: Logging is expensive in encoded reader path
> -------------------------------------------------
>
> Key: HIVE-21369
> URL: https://issues.apache.org/jira/browse/HIVE-21369
> Project: Hive
> Issue Type: Bug
> Components: Logging
> Affects Versions: 4.0.0, 3.2.0
> Reporter: Prasanth Jayachandran
> Assignee: Nita Dembla
> Priority: Major
> Attachments: HIVE-21369.patch
>
>
> There should be no INFO logging in EncodedReaderImpl. Stringifying of disk ranges is expensive in core read path.
> {code:java}
> 2019-03-01T17:55:56.322852142Z 2019-03-01T17:55:56,306 INFO [IO-Elevator-Thread-3 (hive_20190301175546_a279f33c-4f2b-4cd5-8695-57bc8b042a61)] encoded.EncodedReaderImpl: Disk ranges after cache (found everything true; file [-3693547618692831801, 1551190876000, 1047660824], base offset 792920167): [{start: 887940 end: 1003508 cache buffer: 0x5165f83d(1)}, {start: 1003508 end: 1119078 cache buffer: 0xb63cac3(1)}, {start: 1119078 end: 1234745 cache buffer: 0x41a724fa(1)}, {start: 1234745 end: 1350261 cache buffer: 0x2f71bc38(1)}, {start: 1350261 end: 1465752 cache buffer: 0x2c38e1bb(1)}, {start: 1465752 end: 1581231 cache buffer: 0x5827982(1)}, {start: 1581231 end: 1696885 cache buffer: 0x75a6773c(1)}, {start: 1696885 end: 1812492 cache buffer: 0x2ed060f9(1)},{start: 1812492 end: 1928086 cache buffer: 0x20b2c8aa(1)}, {start: 1928086 end: 2043588 cache buffer: 0x6559aacb(1)}, {start: 2043588 end: 2159089 cache buffer: 0x569c85e1(1)}, {start: 2159089 end: 2274725 cache buffer: 0x25a88dd0(1)}, {start: 2274725 end: 2390228 cache buffer: 0x738b7e87(1)}, {start: 2390228 end: 2505715 cache buffer: 0x26edafa0(1)}, {start: 2505715 end: 2621322 cache buffer: 0x69db7752(1)}, {start: 2621322 end: 2736844 cache b{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)