[jira] [Commented] (THRIFT-3874) _TSPEC is not populated on de-serialization of type classes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15518033#comment-15518033 ] 

ASF GitHub Bot commented on THRIFT-3874:
----------------------------------------

Github user sashakavun closed the pull request at:

    https://github.com/apache/thrift/pull/1042


> _TSPEC is not populated on de-serialization of type classes
> -----------------------------------------------------------
>
>                 Key: THRIFT-3874
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3874
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Compiler
>    Affects Versions: 0.9.3
>            Reporter: Aleksandr Kavun
>
> When type class which was serialized and deserialized by internal PHP functions (for example, if data was stored to memcache and then retrieved) is used in requests, thrift_extension gives an 'Attempt to send non-Thrift object as a T_STRUCT' error.
> This is because thrift_extension binary_serialize() function is tries to access to the $_TSPEC static property of object to determine it's target structure. Static $_TSPEC array for generated PHP classes is populated in __construct(). But when objects are deserialized, __construct() isn't called, instead of that PHP calls __wakeup() function. So type class should be instantiated once before sending it via Thrift.
> The solution is to move code that populates $_TSPEC out of constructor to the generic function, and call this function both in __construct() and __wakeup() functions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)