You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/08 17:38:58 UTC
[GitHub] [pulsar] geomagilles opened a new pull request #9153: [docs] add batching in limitations of key-shared mode
geomagilles opened a new pull request #9153:
URL: https://github.com/apache/pulsar/pull/9153
### Motivation
Using KeyShared with batching can lead to vicious bugs as batching remove the guarantee of having a unique consumer handling a given key. I've spent some time debugging this and think it worth stating that in the key-shared limitation
### Modifications
Just added Batching as a limitation of Key-Shared mode.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
yes
This change is already covered by existing tests, such as *(please describe tests)*.
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #9153: [docs] add batching in limitations of key-shared mode
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #9153:
URL: https://github.com/apache/pulsar/pull/9153#issuecomment-757277598
@codelipenghui thank you for letting me know about it. I'll check and fix them if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9153: [docs] add batching in limitations of key-shared mode
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9153:
URL: https://github.com/apache/pulsar/pull/9153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9153: [docs] add batching in limitations of key-shared mode
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9153:
URL: https://github.com/apache/pulsar/pull/9153#issuecomment-757069932
@Jennifer88huang Please help double-check if this change also needs to apply on 2.7.x 2.6.x ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9153: [docs] add batching in limitations of key-shared mode
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9153:
URL: https://github.com/apache/pulsar/pull/9153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #9153: [docs] add batching in limitations of key-shared mode
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #9153:
URL: https://github.com/apache/pulsar/pull/9153#issuecomment-757277598
@codelipenghui thank you for letting me know about it. I'll check and fix them if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9153: [docs] add batching in limitations of key-shared mode
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9153:
URL: https://github.com/apache/pulsar/pull/9153#issuecomment-757069932
@Jennifer88huang Please help double-check if this change also needs to apply on 2.7.x 2.6.x ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9153: [docs] add batching in limitations of key-shared mode
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9153:
URL: https://github.com/apache/pulsar/pull/9153#issuecomment-756903979
@geomagilles I think you can enable KeyBatcher in your producers to group messages by key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9153: [docs] add batching in limitations of key-shared mode
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9153:
URL: https://github.com/apache/pulsar/pull/9153#issuecomment-756903979
@geomagilles I think you can enable KeyBatcher in your producers to group messages by key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org