You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/04/26 02:12:03 UTC

[jira] [Created] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
-----------------------------------------------------------------------------------

                 Key: MPOM-9
                 URL: https://issues.apache.org/jira/browse/MPOM-9
             Project: Maven POM
          Issue Type: Bug
    Affects Versions: ASF-9
            Reporter: Sebb


The apache-release profile contains the following settings:

            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-gpg-plugin</artifactId>
            <configuration>
              <passphrase>${gpg.passphrase}</passphrase>
              <useAgent>true</useAgent>
            </configuration>

This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.

The code should use the relevant property, i.e.

  <properties>
    <gpg.useagent>true</gpg.useagent>
    ...
  </properties>

...
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-gpg-plugin</artifactId>
            <configuration>
              <passphrase>${gpg.passphrase}</passphrase>
              <useAgent>${gpg.useagent}</useAgent>
            </configuration>

This would still default to true, but would allow command-line override.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Posted by "Sebb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MPOM-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb reopened MPOM-9:
---------------------


In retrospect, I think deleting the <useAgent> tag is better.

> Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
> -----------------------------------------------------------------------------------
>
>                 Key: MPOM-9
>                 URL: https://issues.apache.org/jira/browse/MPOM-9
>             Project: Maven POM
>          Issue Type: Bug
>    Affects Versions: ASF-9
>            Reporter: Sebb
>            Assignee: Olivier Lamy
>            Priority: Critical
>
> The apache-release profile contains the following settings:
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>true</useAgent>
>             </configuration>
> This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.
> The code should use the relevant property, i.e.
>   <properties>
>     <gpg.useagent>true</gpg.useagent>
>     ...
>   </properties>
> ...
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>${gpg.useagent}</useAgent>
>             </configuration>
> This would still default to true, but would allow command-line override.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Posted by "Sebb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MPOM-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029852#comment-13029852 ] 

Sebb commented on MPOM-9:
-------------------------

When using GPG 1.x, the current settings cause Maven to hang unless the passphrase is provided on the command-line.

It might be better just to drop the <useAgent> line altogether.

> Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
> -----------------------------------------------------------------------------------
>
>                 Key: MPOM-9
>                 URL: https://issues.apache.org/jira/browse/MPOM-9
>             Project: Maven POM
>          Issue Type: Bug
>    Affects Versions: ASF-9
>            Reporter: Sebb
>
> The apache-release profile contains the following settings:
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>true</useAgent>
>             </configuration>
> This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.
> The code should use the relevant property, i.e.
>   <properties>
>     <gpg.useagent>true</gpg.useagent>
>     ...
>   </properties>
> ...
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>${gpg.useagent}</useAgent>
>             </configuration>
> This would still default to true, but would allow command-line override.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MPOM-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030000#comment-13030000 ] 

Hudson commented on MPOM-9:
---------------------------

Integrated in ASF Parent Pom #16 (See [https://builds.apache.org/hudson/job/ASF%20Parent%20Pom/16/])
    [MPOM-9] Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
Submitted by Sebb


> Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
> -----------------------------------------------------------------------------------
>
>                 Key: MPOM-9
>                 URL: https://issues.apache.org/jira/browse/MPOM-9
>             Project: Maven POM
>          Issue Type: Bug
>    Affects Versions: ASF-9
>            Reporter: Sebb
>            Assignee: Olivier Lamy
>            Priority: Critical
>
> The apache-release profile contains the following settings:
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>true</useAgent>
>             </configuration>
> This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.
> The code should use the relevant property, i.e.
>   <properties>
>     <gpg.useagent>true</gpg.useagent>
>     ...
>   </properties>
> ...
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>${gpg.useagent}</useAgent>
>             </configuration>
> This would still default to true, but would allow command-line override.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Posted by "Sebb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MPOM-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030168#comment-13030168 ] 

Sebb commented on MPOM-9:
-------------------------

Because the <useAgent> setting is installation dependent it does not make much sense to define it in the pom.

Perhaps more important, the default for the maven-gpg-plugin is useAgent=false.
Changing the default to true may cause a surprise for GPG1 users (as happened in Commons, when GPG started hanging)


> Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
> -----------------------------------------------------------------------------------
>
>                 Key: MPOM-9
>                 URL: https://issues.apache.org/jira/browse/MPOM-9
>             Project: Maven POM
>          Issue Type: Bug
>    Affects Versions: ASF-9
>            Reporter: Sebb
>            Assignee: Olivier Lamy
>            Priority: Critical
>
> The apache-release profile contains the following settings:
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>true</useAgent>
>             </configuration>
> This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.
> The code should use the relevant property, i.e.
>   <properties>
>     <gpg.useagent>true</gpg.useagent>
>     ...
>   </properties>
> ...
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>${gpg.useagent}</useAgent>
>             </configuration>
> This would still default to true, but would allow command-line override.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Posted by "Olivier Lamy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MPOM-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy closed MPOM-9.
---------------------------

    Resolution: Fixed
      Assignee: Olivier Lamy

fixed rev 1100257.
Thanks !

> Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
> -----------------------------------------------------------------------------------
>
>                 Key: MPOM-9
>                 URL: https://issues.apache.org/jira/browse/MPOM-9
>             Project: Maven POM
>          Issue Type: Bug
>    Affects Versions: ASF-9
>            Reporter: Sebb
>            Assignee: Olivier Lamy
>            Priority: Critical
>
> The apache-release profile contains the following settings:
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>true</useAgent>
>             </configuration>
> This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.
> The code should use the relevant property, i.e.
>   <properties>
>     <gpg.useagent>true</gpg.useagent>
>     ...
>   </properties>
> ...
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>${gpg.useagent}</useAgent>
>             </configuration>
> This would still default to true, but would allow command-line override.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Posted by "Sebb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MPOM-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated MPOM-9:
--------------------

    Priority: Critical  (was: Major)

> Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
> -----------------------------------------------------------------------------------
>
>                 Key: MPOM-9
>                 URL: https://issues.apache.org/jira/browse/MPOM-9
>             Project: Maven POM
>          Issue Type: Bug
>    Affects Versions: ASF-9
>            Reporter: Sebb
>            Priority: Critical
>
> The apache-release profile contains the following settings:
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>true</useAgent>
>             </configuration>
> This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.
> The code should use the relevant property, i.e.
>   <properties>
>     <gpg.useagent>true</gpg.useagent>
>     ...
>   </properties>
> ...
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>${gpg.useagent}</useAgent>
>             </configuration>
> This would still default to true, but would allow command-line override.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MPOM-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benson Margulies updated MPOM-9:
--------------------------------

    Component/s: asf

> Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
> -----------------------------------------------------------------------------------
>
>                 Key: MPOM-9
>                 URL: https://issues.apache.org/jira/browse/MPOM-9
>             Project: Maven POM
>          Issue Type: Bug
>          Components: asf
>    Affects Versions: ASF-9
>            Reporter: Sebb
>            Assignee: Olivier Lamy
>            Priority: Critical
>
> The apache-release profile contains the following settings:
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>true</useAgent>
>             </configuration>
> This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.
> The code should use the relevant property, i.e.
>   <properties>
>     <gpg.useagent>true</gpg.useagent>
>     ...
>   </properties>
> ...
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>${gpg.useagent}</useAgent>
>             </configuration>
> This would still default to true, but would allow command-line override.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Posted by "Sebb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MPOM-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029852#comment-13029852 ] 

Sebb edited comment on MPOM-9 at 5/6/11 10:58 AM:
--------------------------------------------------

When using GPG 1.x, the current settings cause Maven to hang unless the passphrase is provided on the command-line.

It might be better just to drop the <useAgent> line altogether - this should be defined in the user's settings.xml as it relates to the host gpg installation.

      was (Author: sebb@apache.org):
    When using GPG 1.x, the current settings cause Maven to hang unless the passphrase is provided on the command-line.

It might be better just to drop the <useAgent> line altogether.
  
> Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
> -----------------------------------------------------------------------------------
>
>                 Key: MPOM-9
>                 URL: https://issues.apache.org/jira/browse/MPOM-9
>             Project: Maven POM
>          Issue Type: Bug
>    Affects Versions: ASF-9
>            Reporter: Sebb
>            Priority: Critical
>
> The apache-release profile contains the following settings:
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>true</useAgent>
>             </configuration>
> This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.
> The code should use the relevant property, i.e.
>   <properties>
>     <gpg.useagent>true</gpg.useagent>
>     ...
>   </properties>
> ...
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>${gpg.useagent}</useAgent>
>             </configuration>
> This would still default to true, but would allow command-line override.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MPOM-9) Apache Parent POM 9 does not allow override of in apache-release profile

Posted by "Olivier Lamy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MPOM-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030148#comment-13030148 ] 

Olivier Lamy commented on MPOM-9:
---------------------------------

any reason for that ?
AFAIK with the change you can easily override in settings or with a property in your pom 

> Apache Parent POM 9 does not allow override of <useAgent> in apache-release profile
> -----------------------------------------------------------------------------------
>
>                 Key: MPOM-9
>                 URL: https://issues.apache.org/jira/browse/MPOM-9
>             Project: Maven POM
>          Issue Type: Bug
>    Affects Versions: ASF-9
>            Reporter: Sebb
>            Assignee: Olivier Lamy
>            Priority: Critical
>
> The apache-release profile contains the following settings:
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>true</useAgent>
>             </configuration>
> This is bad, because it unconditionally forces the use of an agent which may not be appropriate for all use cases.
> The code should use the relevant property, i.e.
>   <properties>
>     <gpg.useagent>true</gpg.useagent>
>     ...
>   </properties>
> ...
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-gpg-plugin</artifactId>
>             <configuration>
>               <passphrase>${gpg.passphrase}</passphrase>
>               <useAgent>${gpg.useagent}</useAgent>
>             </configuration>
> This would still default to true, but would allow command-line override.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira