[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6345: Spark 3.3: Choose readers based on task types

[GitBox <gi...@apache.org>]

RussellSpitzer commented on code in PR #6345:
URL: https://github.com/apache/iceberg/pull/6345#discussion_r1038439238


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkInputPartition.java:
##########
@@ -66,6 +66,10 @@ public <T extends ScanTask> ScanTaskGroup<T> taskGroup() {
     return (ScanTaskGroup<T>) taskGroup;
   }
 
+  public <T extends ScanTask> boolean allTasksOfType(Class<T> javaClass) {

Review Comment:
   Do we allow a taskgroup to have tasks of different types? I didn't think so. But I don't think it costs us that much to just check all of them instead of just the first element.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org