You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "jasonosullivan34 (via GitHub)" <gi...@apache.org> on 2026/05/07 10:51:23 UTC
[PR] HDDS-15199. Fix StartQuotaRepair client ignoring bucket list [ozone]
jasonosullivan34 opened a new pull request, #10208:
URL: https://github.com/apache/ozone/pull/10208
## What changes were proposed in this pull request?
HDDS-15199. Fix StartQuotaRepair client ignoring bucket list
Please describe your PR in detail:
Populate `StartQuotaRepairRequest` with the bucket list in `OzoneManagerProtocolClientSideTranslatorPB.startQuotaRepair` so scoped `ozone repair quota start --buckets=...` reaches the Ozone Manager instead of always running a full-cluster repair.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15199
## How was this patch tested?
Manual Tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15199. Fix StartQuotaRepair client ignoring bucket list [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang merged PR #10208:
URL: https://github.com/apache/ozone/pull/10208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15199. Fix StartQuotaRepair client ignoring bucket list [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #10208:
URL: https://github.com/apache/ozone/pull/10208#issuecomment-4453542620
Merged. Thanks @jasonosullivan34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15199. Fix StartQuotaRepair client ignoring bucket list [ozone]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #10208:
URL: https://github.com/apache/ozone/pull/10208#discussion_r3230120058
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -2676,6 +2676,7 @@ public String getQuotaRepairStatus() throws IOException {
public void startQuotaRepair(List<String> buckets) throws IOException {
OzoneManagerProtocolProtos.StartQuotaRepairRequest startQuotaRepairRequest =
OzoneManagerProtocolProtos.StartQuotaRepairRequest.newBuilder()
+ .addAllBuckets(buckets)
.build();
Review Comment:
`addAllBuckets(buckets)` will throw a NullPointerException if callers pass `null`. Previously `startQuotaRepair(null)` would have worked (it just sent an empty request), so this is a behavior change that can break existing callers. Consider explicitly handling `null` (treat as empty list) or validate with a clear precondition/exception, and add a unit test covering the chosen behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org