You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/04/05 15:10:18 UTC
[GitHub] [camel-k] squakez opened a new pull request, #3172: fix(olm): IntegrationPlatform reconciled by operator
squakez opened a new pull request, #3172:
URL: https://github.com/apache/camel-k/pull/3172
<!-- Description -->
Closes #3161
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
fix(olm): IntegrationPlatform reconciled by operator
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3172: fix(olm): IntegrationPlatform reconciled by operator
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3172:
URL: https://github.com/apache/camel-k/pull/3172#issuecomment-1088842717
fyi @astefanutti @lburgazzoli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3172: fix(olm): IntegrationPlatform reconciled by operator
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3172:
URL: https://github.com/apache/camel-k/pull/3172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3172: fix(olm): IntegrationPlatform reconciled by operator
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3172:
URL: https://github.com/apache/camel-k/pull/3172#issuecomment-1096442125
We'll need to include a proper E2E test for OLM installation once #3180 is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3172: fix(olm): IntegrationPlatform reconciled by operator
Posted by GitBox <gi...@apache.org>.
astefanutti commented on PR #3172:
URL: https://github.com/apache/camel-k/pull/3172#issuecomment-1090017708
> > The annotation should probably be transported also here:
> > https://github.com/apache/camel-k/blob/7942108bf0e00b322580387773eb7222bc6c0d18/pkg/trait/platform.go#L118
>
> I've tried to cascade the annotation there, but I noticed that we cannot reach that point because we always get the IntegrationPlatform present in the operator namespace (see
>
> https://github.com/apache/camel-k/blob/7942108bf0e00b322580387773eb7222bc6c0d18/pkg/trait/platform.go#L104
>
> )
Even when the operator is installed with OLM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3172: fix(olm): IntegrationPlatform reconciled by operator
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3172:
URL: https://github.com/apache/camel-k/pull/3172#issuecomment-1090051771
> Even when the operator is installed with OLM?
I haven't tested that scenario. Let me check how it is affected in such case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3172: fix(olm): IntegrationPlatform reconciled by operator
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3172:
URL: https://github.com/apache/camel-k/pull/3172#discussion_r847947275
##########
e2e/common/cli/install_test.go:
##########
@@ -24,27 +24,27 @@ package common
import (
"bytes"
- "github.com/apache/camel-k/pkg/install"
- "github.com/apache/camel-k/pkg/util/defaults"
- "github.com/apache/camel-k/pkg/util/kubernetes"
- "github.com/apache/camel-k/pkg/util/openshift"
- console "github.com/openshift/api/console/v1"
Review Comment:
looks like build error here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3172: fix(olm): IntegrationPlatform reconciled by operator
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3172:
URL: https://github.com/apache/camel-k/pull/3172#issuecomment-1090007861
> The annotation should probably be transported also here:
>
> https://github.com/apache/camel-k/blob/7942108bf0e00b322580387773eb7222bc6c0d18/pkg/trait/platform.go#L118
I've tried to cascade the annotation there, but I noticed that we cannot reach that point because we always get the IntegrationPlatform present in the operator namespace (see https://github.com/apache/camel-k/blob/7942108bf0e00b322580387773eb7222bc6c0d18/pkg/trait/platform.go#L104)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3172: fix(olm): IntegrationPlatform reconciled by operator
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3172:
URL: https://github.com/apache/camel-k/pull/3172#discussion_r848421406
##########
e2e/common/cli/install_test.go:
##########
@@ -24,27 +24,27 @@ package common
import (
"bytes"
- "github.com/apache/camel-k/pkg/install"
- "github.com/apache/camel-k/pkg/util/defaults"
- "github.com/apache/camel-k/pkg/util/kubernetes"
- "github.com/apache/camel-k/pkg/util/openshift"
- console "github.com/openshift/api/console/v1"
Review Comment:
Good catch, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org