You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/10/22 23:14:08 UTC
[GitHub] [helix] xyuanlu opened a new pull request #1897: Api change for mm
xyuanlu opened a new pull request #1897:
URL: https://github.com/apache/helix/pull/1897
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#1896
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
- Refactor current health check in instanceService into the cluster maintenance service.
- Add an abstract class OperationAbstractClass for customized operation check and execution implementation.
-
### Tests
- [X] The following tests are written for this issue:
TestMaintenanceManagementService.java
- The following is the result of the "mvn test" command on the appropriate module:
```
[INFO] Results:
[INFO]
[INFO] Tests run: 179, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report) @ helix-rest ---
[INFO] Loading execution data file /Users/xialu/Documents/WorkSpace/helix/helix-rest/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Restful Interface' with 82 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:52 min
[INFO] Finished at: 2021-10-22T15:01:35-07:00
[INFO] ------------------------------------------------------------------------
```
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu closed pull request #1897: Add clusterMaintenanceService in helix-rest
Posted by GitBox <gi...@apache.org>.
xyuanlu closed pull request #1897:
URL: https://github.com/apache/helix/pull/1897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1897: Add clusterMaintenanceService in helix-rest
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1897:
URL: https://github.com/apache/helix/pull/1897#issuecomment-954161386
> Give you a general suggestion. Better we split the PR into : 1) new logics new class creation and 2) pure refactoring like moving logics from class to another.
>
> That can help us review it in an easy mode.
Thanks for the suggestion. Will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org