You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Michelle Caisse (JIRA)" <ji...@apache.org> on 2005/09/22 18:20:27 UTC
[jira] Created: (JDO-147) Remove pm.deletePersistent from query tests
Remove pm.deletePersistent from query tests
-------------------------------------------
Key: JDO-147
URL: http://issues.apache.org/jira/browse/JDO-147
Project: JDO
Type: Bug
Components: tck20
Reporter: Michelle Caisse
Assigned to: Michael Watzek
The query tests delete the persistent instance that they create at the end of the test using pm.deletePersistent(). Now that we use the new cleanup mechanism (addTearDownClass(Class)), there is no reason to deletie the instance. Also, the new maven option jdo.tck.cleanupaftertest cannot override this cleanup, so you can never see the database contents for debugging. Therefore, we should remove the line that deletes the persistent instance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JDO-147) Remove pm.deletePersistent from query tests
Posted by "Michael Watzek (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-147?page=all ]
Michael Watzek updated JDO-147:
-------------------------------
Attachment: JDO-147.patch
The attached patch fixes this issue.
Methods QueryTest.cleanupCompanyModel and QueryTest.cleanupDatabase have been removed. Instead, localSetup methods have been introduced in all JDO1 query tests.
All JDO1 query tests (except jdoql.operator tests) have been adapted to make use of the query framework implemented for JDO2 query tests. Thus, JDO1 query tests cases are executed as API queries and as single string queries. Furthermore, this ensures that JDO1 and JDO2 use the same logging infrastructure.
Additionally, methods QueryTest.getCompanyModelInstanceXXX have been removed. Instead, methods QueryTest.getPersistentCompanyModelInstanceXXX and QueryTest.getTransientCompanyModelInstanceXXX have been introduced. The expected result of queries is initialized using QueryTest.getTransientCompanyModelInstanceXXX. Parameters of queries are initialized using QueryTest.getPerisistentCompanyModelInstanceXXX. The same holds true for QueryTest.getMylibInstanceXXX methods.
> Remove pm.deletePersistent from query tests
> -------------------------------------------
>
> Key: JDO-147
> URL: http://issues.apache.org/jira/browse/JDO-147
> Project: JDO
> Type: Bug
> Components: tck20
> Reporter: Michelle Caisse
> Assignee: Michael Watzek
> Attachments: JDO-147.patch
>
> The query tests delete the persistent instance that they create at the end of the test using pm.deletePersistent(). Now that we use the new cleanup mechanism (addTearDownClass(Class)), there is no reason to deletie the instance. Also, the new maven option jdo.tck.cleanupaftertest cannot override this cleanup, so you can never see the database contents for debugging. Therefore, we should remove the line that deletes the persistent instance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-147) Remove pm.deletePersistent from query tests
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-147?page=comments#action_12359134 ]
Michael Bouschen commented on JDO-147:
--------------------------------------
Looks good!
Just a minor comment: please add to the javadoc of QueryTest.makePersistentAll that it starts its own transaction.
> Remove pm.deletePersistent from query tests
> -------------------------------------------
>
> Key: JDO-147
> URL: http://issues.apache.org/jira/browse/JDO-147
> Project: JDO
> Type: Bug
> Components: tck20
> Reporter: Michelle Caisse
> Assignee: Michael Watzek
> Attachments: JDO-147.patch
>
> The query tests delete the persistent instance that they create at the end of the test using pm.deletePersistent(). Now that we use the new cleanup mechanism (addTearDownClass(Class)), there is no reason to deletie the instance. Also, the new maven option jdo.tck.cleanupaftertest cannot override this cleanup, so you can never see the database contents for debugging. Therefore, we should remove the line that deletes the persistent instance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-147) Remove pm.deletePersistent from query tests
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-147?page=comments#action_12359141 ]
Michael Bouschen commented on JDO-147:
--------------------------------------
Oops, I forgot two comments:
- Class StringConcatenation defines a field parameters for the actual parameters of the test queries. The first entry defines null as the actual parameter for te first query, but the test query does not define any parameter.
- In class DenoteUniquenessInFilter the comment in the declaratuon of expectedResult does not match the values use as expected result. Please check the test query and adapt the comment.
> Remove pm.deletePersistent from query tests
> -------------------------------------------
>
> Key: JDO-147
> URL: http://issues.apache.org/jira/browse/JDO-147
> Project: JDO
> Type: Bug
> Components: tck20
> Reporter: Michelle Caisse
> Assignee: Michael Watzek
> Attachments: JDO-147.patch
>
> The query tests delete the persistent instance that they create at the end of the test using pm.deletePersistent(). Now that we use the new cleanup mechanism (addTearDownClass(Class)), there is no reason to deletie the instance. Also, the new maven option jdo.tck.cleanupaftertest cannot override this cleanup, so you can never see the database contents for debugging. Therefore, we should remove the line that deletes the persistent instance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-147) Remove pm.deletePersistent from query tests
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-147?page=comments#action_12359142 ]
Michael Bouschen commented on JDO-147:
--------------------------------------
Oops, I forgot two comments:
- Class StringConcatenation defines a field parameters for the actual parameters of the test queries. The first entry defines null as the actual parameter for te first query, but the test query does not define any parameter.
- In class DenoteUniquenessInFilter the comment in the declaratuon of expectedResult does not match the values use as expected result. Please check the test query and adapt the comment.
> Remove pm.deletePersistent from query tests
> -------------------------------------------
>
> Key: JDO-147
> URL: http://issues.apache.org/jira/browse/JDO-147
> Project: JDO
> Type: Bug
> Components: tck20
> Reporter: Michelle Caisse
> Assignee: Michael Watzek
> Attachments: JDO-147.patch
>
> The query tests delete the persistent instance that they create at the end of the test using pm.deletePersistent(). Now that we use the new cleanup mechanism (addTearDownClass(Class)), there is no reason to deletie the instance. Also, the new maven option jdo.tck.cleanupaftertest cannot override this cleanup, so you can never see the database contents for debugging. Therefore, we should remove the line that deletes the persistent instance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JDO-147) Remove pm.deletePersistent from query tests
Posted by "Michael Watzek (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-147?page=all ]
Michael Watzek resolved JDO-147:
--------------------------------
Resolution: Fixed
The comments above have been incorporated into the attached patch. The patch has been checked in (Revision 351768).
> Remove pm.deletePersistent from query tests
> -------------------------------------------
>
> Key: JDO-147
> URL: http://issues.apache.org/jira/browse/JDO-147
> Project: JDO
> Type: Bug
> Components: tck20
> Reporter: Michelle Caisse
> Assignee: Michael Watzek
> Attachments: JDO-147.patch
>
> The query tests delete the persistent instance that they create at the end of the test using pm.deletePersistent(). Now that we use the new cleanup mechanism (addTearDownClass(Class)), there is no reason to deletie the instance. Also, the new maven option jdo.tck.cleanupaftertest cannot override this cleanup, so you can never see the database contents for debugging. Therefore, we should remove the line that deletes the persistent instance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira