You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Trustin Lee (JIRA)" <ji...@apache.org> on 2008/04/07 13:10:24 UTC

[jira] Created: (DIRMINA-566) ConnectionThrottleFilter doesn't forward sessionCreated event.

ConnectionThrottleFilter doesn't forward sessionCreated event.
--------------------------------------------------------------

                 Key: DIRMINA-566
                 URL: https://issues.apache.org/jira/browse/DIRMINA-566
             Project: MINA
          Issue Type: Bug
          Components: Filter
    Affects Versions: 2.0.0-M1
            Reporter: Trustin Lee
            Assignee: Trustin Lee
             Fix For: 2.0.0-M2


If you look into ConnectionThrottleFilter.sessionCreated():

    @Override
    public void sessionCreated(NextFilter nextFilter, IoSession session)
            throws Exception {
        if (!isConnectionOk(session)) {
            logger.warn("Connections coming in too fast; closing.");
            session.close();
        }
    }

ConnectionThrottleFilter doesn't forward sessionCreated event to the next filter.  It should look like the following:

    @Override
    public void sessionCreated(NextFilter nextFilter, IoSession session)
            throws Exception {
        if (!isConnectionOk(session)) {
            logger.warn("Connections coming in too fast; closing.");
            session.close();
        }
        nextFilter.sessionCreated(session);
    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRMINA-566) ConnectionThrottleFilter doesn't forward sessionCreated event.

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee closed DIRMINA-566.
-------------------------------

    Resolution: Fixed

> ConnectionThrottleFilter doesn't forward sessionCreated event.
> --------------------------------------------------------------
>
>                 Key: DIRMINA-566
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-566
>             Project: MINA
>          Issue Type: Bug
>          Components: Filter
>    Affects Versions: 2.0.0-M1
>            Reporter: Trustin Lee
>            Assignee: Trustin Lee
>             Fix For: 2.0.0-M2
>
>
> If you look into ConnectionThrottleFilter.sessionCreated():
>     @Override
>     public void sessionCreated(NextFilter nextFilter, IoSession session)
>             throws Exception {
>         if (!isConnectionOk(session)) {
>             logger.warn("Connections coming in too fast; closing.");
>             session.close();
>         }
>     }
> ConnectionThrottleFilter doesn't forward sessionCreated event to the next filter.  It should look like the following:
>     @Override
>     public void sessionCreated(NextFilter nextFilter, IoSession session)
>             throws Exception {
>         if (!isConnectionOk(session)) {
>             logger.warn("Connections coming in too fast; closing.");
>             session.close();
>         }
>         nextFilter.sessionCreated(session);
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.