trunk/AOO341: how is --disable-category-b --enable-hunspell supposed to work?

[Pavel Janík <pa...@janik.cz>]

Hi,

configure --help says:

  --enable-category-b     Activate components under a category B license 
                          (see http://www.apache.org/legal/3party.html#category-b):
                          MPL (seamonkey, hunspell, hyphen, nss, saxon, rhino),
                          CPL (silgraphite), CPL/EPL (CoinMP), SPL (beanshell),
                          OFL (fonts).
                          Flags for individual libraries override this one.

How is this "overriding" supposed to work?

First configure check --enable-category-b and RESETS the enable_hunspell on both yes and no in enable-category-b. This way, the code later on doesn't know what user entered on the command line:

if test "$enable_category_b" = "yes"; then
   ENABLE_CATEGORY_B=YES
   enable_hunspell="yes"
   enable_hyphen="yes"
   enable_saxon="yes"
   enable_javascript="yes"
   enable_beanshell="yes"
   enable_graphite="yes"
   enable_coinmp="yes"
   enable_category_b_fonts="yes"

   AC_MSG_RESULT([yes: allow modules moz, nss, hunspell, hyphen, saxon, rhino, beanshell, graphite, coinmp to be built])
else
   # Disable libaries.
   enable_mozilla="no"
   enable_nss_module="no"
   enable_hunspell="no"
   enable_hyphen="no"
   enable_saxon="no"
   enable_javascript="no"
   enable_beanshell="no"
   enable_graphite="no"
   enable_coinmp="no"
   enable_category_b_fonts="no"

   AC_MSG_RESULT([no: disabled modules moz, nss, hunspell, hyphen, saxon, rhino, beanshell, graphite, coinmp])
fi

-- 
Pavel Janík

Re: trunk/AOO341: how is --disable-category-b --enable-hunspell supposed to work?

[Pavel Janík <Pa...@Janik.cz>]

On Jan 26, 2013, at 11:20 AM, Pavel Janík wrote:

>  --enable-category-b     Activate components under a category B license 
>                          (see http://www.apache.org/legal/3party.html#category-b):
>                          MPL (seamonkey, hunspell, hyphen, nss, saxon, rhino),
>                          CPL (silgraphite), CPL/EPL (CoinMP), SPL (beanshell),
>                          OFL (fonts).
>                          Flags for individual libraries override this one.
> 
> How is this "overriding" supposed to work?

And to add even more, external_deps.lst contains:

if (ENABLE_CATEGORY_B==YES && ENABLE_HUNSPELL==YES)
    name = hunspell-1.3.2.tar.gz
    MD5 = 3121aaf3e13e5d88dfff13fb4a5f1ab8
    URL1 = http://sourceforge.net/projects/hunspell/files/Hunspell/1.3.2/hunspell-1.3.2.tar.gz/download
    URL2 = $(OOO_EXTRAS)$(MD5)-$(name)
    URL3 = $(SVN_TRUNK)$(MD5)-$(name)

Ie. it EXPECTS category B enabled anyway. So it is not possible at all to use --disable-category-b --enable-hunspell to get only hunspell.
-- 
Pavel Janík