You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/07/28 09:45:11 UTC
[GitHub] [kylin] hit-lacus opened a new pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
hit-lacus opened a new pull request #1702:
URL: https://github.com/apache/kylin/pull/1702
- remove unused maven module, include core-dictionary and datasource-sdk
- remove out-of-date UTs
- all source code are not deleted but commented, should deleted them later
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1702:
URL: https://github.com/apache/kylin/pull/1702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1702:
URL: https://github.com/apache/kylin/pull/1702#issuecomment-888199035
This pull request **fixes 14 alerts** when merging 5bd8f58710038764aacdced2a12e40ad0f8348e1 into 9f7e5316effee916605cb883f9accfa46b849071 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-98da95ede19baf3f378b211788d3c57dba6d5adf)
**fixed alerts:**
* 3 for Boxed variable is never null
* 2 for Useless comparison test
* 2 for Query built from user\-controlled sources
* 2 for Dereferenced variable may be null
* 2 for Unused format argument
* 1 for Result of multiplication cast to wider type
* 1 for Implicit narrowing conversion in compound assignment
* 1 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1702:
URL: https://github.com/apache/kylin/pull/1702#issuecomment-890836554
This pull request **fixes 14 alerts** when merging 14b1bfd1d3900d6d9a37bda9b5002b3043df346b into f1436a3ea2610a2f41b7b0b89f2db87dd9999909 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-a0715f7c11b0a1c153de7a437d49a2d2a0ff67b4)
**fixed alerts:**
* 3 for Boxed variable is never null
* 2 for Useless comparison test
* 2 for Query built from user\-controlled sources
* 2 for Dereferenced variable may be null
* 2 for Unused format argument
* 1 for Result of multiplication cast to wider type
* 1 for Implicit narrowing conversion in compound assignment
* 1 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1702:
URL: https://github.com/apache/kylin/pull/1702#issuecomment-888983573
This pull request **fixes 14 alerts** when merging 4fc8ee4755545a6f2baf23a60010a645ef6271db into 9f7e5316effee916605cb883f9accfa46b849071 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-6ace1f86f416e0014af9604de9d4b1a81d6fa81e)
**fixed alerts:**
* 3 for Boxed variable is never null
* 2 for Useless comparison test
* 2 for Query built from user\-controlled sources
* 2 for Dereferenced variable may be null
* 2 for Unused format argument
* 1 for Result of multiplication cast to wider type
* 1 for Implicit narrowing conversion in compound assignment
* 1 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1702:
URL: https://github.com/apache/kylin/pull/1702#issuecomment-888250843
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1702?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@9f7e531`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1702 +/- ##
======================================================
Coverage ? 24.63%
Complexity ? 4451
======================================================
Files ? 1092
Lines ? 61876
Branches ? 8888
======================================================
Hits ? 15241
Misses ? 45027
Partials ? 1608
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1702?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1702?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9f7e531...42acc52](https://codecov.io/gh/apache/kylin/pull/1702?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus edited a comment on pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on pull request #1702:
URL: https://github.com/apache/kylin/pull/1702#issuecomment-888172224
## Test Evidence
#### UT & IT
- mvn clean test -DskipRunIt=false
- mvn clean test -Pspark3 -Psandbox -DskipRunIt=false
#### Manual test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1702:
URL: https://github.com/apache/kylin/pull/1702#issuecomment-888236221
This pull request **fixes 14 alerts** when merging 42acc5264b03a7ecb5e17f716daae62dc7d36acc into 9f7e5316effee916605cb883f9accfa46b849071 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-f9db86bd3aac10cc03d269eb6d4df410dda57304)
**fixed alerts:**
* 3 for Boxed variable is never null
* 2 for Useless comparison test
* 2 for Query built from user\-controlled sources
* 2 for Dereferenced variable may be null
* 2 for Unused format argument
* 1 for Result of multiplication cast to wider type
* 1 for Implicit narrowing conversion in compound assignment
* 1 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1702:
URL: https://github.com/apache/kylin/pull/1702#issuecomment-890777541
This pull request **fixes 14 alerts** when merging 487861133e0e8448423c5c60df2d6eebfaf3e55f into f1436a3ea2610a2f41b7b0b89f2db87dd9999909 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-c7ba008ff0cbd2b09483d6d22ae7e1bd8ecfccb6)
**fixed alerts:**
* 3 for Boxed variable is never null
* 2 for Useless comparison test
* 2 for Query built from user\-controlled sources
* 2 for Dereferenced variable may be null
* 2 for Unused format argument
* 1 for Result of multiplication cast to wider type
* 1 for Implicit narrowing conversion in compound assignment
* 1 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1702: KYLIN-5052 Clean up unused and out-of-date source code/config
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1702:
URL: https://github.com/apache/kylin/pull/1702#issuecomment-888172224
## Test Evidence
#### UT & IT
- mvn clean test -DskipRunIt=false
- mvn clean test -Pspark3 -DskipRunIt=false
#### Manual test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org