You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/29 21:41:58 UTC

[jira] [Commented] (CB-12034) Media plugin should add NSMicrophoneUsageDescription setting to info.plist

    [ https://issues.apache.org/jira/browse/CB-12034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618773#comment-15618773 ] 

ASF GitHub Bot commented on CB-12034:
-------------------------------------

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/119

    CB-12034 (ios) Add mandatory iOS 10 privacy description

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Add mandatory iOS 10 privacy description for microphone usage
    Also formats plugin.xml better and fix some errors on examples
    
    ### What testing has been done on this change?
    tested on iOS 10 device
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-media CB-12034

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #119
    
----
commit 25431e9d7560f528ddc9a9accb1c963f4827a86d
Author: Julio Cesar Sanchez Hernandez <jc...@gmail.com>
Date:   2016-10-29T21:38:54Z

    CB-12034 (ios) Add mandatory iOS 10 privacy description

----


> Media plugin should add NSMicrophoneUsageDescription setting to info.plist
> --------------------------------------------------------------------------
>
>                 Key: CB-12034
>                 URL: https://issues.apache.org/jira/browse/CB-12034
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Plugin Media
>    Affects Versions: 3.5.0
>         Environment: ios10
>            Reporter: Gerard Kromhout
>            Assignee: jcesarmobile
>
> If I add the media plugin and want to use it on iOS10, I have to manually add NSMicrophoneUsageDescription and a description in the project plist.
> It would be nice if things would work the same as the cordova-media-capture plugin:
> cordova plugin add cordova-plugin-media-capture --variable MICROPHONE_USAGE_DESCRIPTION="your usage message"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org