[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1128: e2e-test: Optimize the runtime of ingress/features, and support more default value in NewScaffold

[GitBox <gi...@apache.org>]

tao12345666333 commented on code in PR #1128:
URL: https://github.com/apache/apisix-ingress-controller/pull/1128#discussion_r913080078


##########
test/e2e/suite-ingress/suite-ingress-resource/resourcepushing.go:
##########
@@ -136,9 +130,9 @@ spec:
 
 			// remove
 			assert.Nil(ginkgo.GinkgoT(), s.RemoveResourceByString(apisixRoute))
-			// TODO When ingress controller can feedback the lifecycle of CRDs to the
-			// status field, we can poll it rather than sleeping.
-			time.Sleep(10 * time.Second)
+
+			err = s.EnsureNumApisixUpstreamsCreated(0)
+			assert.Nil(ginkgo.GinkgoT(), err, "Checking number of routes")
 			ups, err := s.ListApisixUpstreams()
 			assert.Nil(ginkgo.GinkgoT(), err, "list upstreams error")
 			assert.Len(ginkgo.GinkgoT(), ups, 0, "upstreams nodes not expect")

Review Comment:
   yes, we can remove this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org