[GitHub] spark pull request: [SPARK-4644][Core] Implement skewed join

[zsxwing <gi...@git.apache.org>]

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3505#discussion_r21147642
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala ---
    @@ -481,9 +481,203 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
        * (k, v2) is in `other`. Uses the given Partitioner to partition the output RDD.
        */
       def join[W](other: RDD[(K, W)], partitioner: Partitioner): RDD[(K, (V, W))] = {
    --- End diff --
    
    A better signature of `join` is `def join[W: ClassTag](other: RDD[(K, W)], partitioner: Partitioner): RDD[(K, (V, W))]`. However, it's a breaking change, so I don't change it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org